Error not correctly thrown when using event registration about factorio-stdlib HOT 3 CLOSED

I wrote a test case to verify that the event was properly sending error messages to players, and it is. I think everything is working as intended, but the problem is that if there are no players online or capable of seeing the message, then the error is essentially hidden from the game. This is why:

(From Event.lua)

            local success, err = pcall(handler, event)
            if not success then
                -- may be nil in on_load
                if _G.game then
                    Game.print_all(err)
                else
                    -- no way to handle errors cleanly when the game is not up
                    error(err)
                end
                return
            end

When the game exists (and it does in your event), then it tries to run Game.print_all with the error message, but if there aren't any players to receive the message, then print_all isn't terribly useful. I think I can improve this - print_all returns the number of players notified, and if this is zero, then I'll raise the error the same way factorio does, so it isn't hidden.

from factorio-stdlib.

The fix is in Factorio Standard Library 0.5.1.

from factorio-stdlib.

I'll try it out today, thanks.

from factorio-stdlib.