Giter VIP home page Giter VIP logo

Comments (5)

afloyd avatar afloyd commented on July 17, 2024

You have to install mongodb separately from mongo-migrate... Mongo-migrate just uses mongodb libraries to querying the database

from mongo-migrate.

newmanw avatar newmanw commented on July 17, 2024

Sure but if mongo-mongrate (npm) is dependent on mongodb (npm) then it should pull it automatically. I should not have to do npm install mongo-migrate and npm install mongodb. Your module should work out of the box by specifying the dependencies in the package.json.

You specify the mongodb dependency but as a dev dependency:

  "devDependencies": {
    "mongodb": "1.3.19"
  },

This means when I do npm install mongo-migrate, that mongodb 1.3.19 is not pulled in as a dependent module. It is dependent your module will not run without it.

Consider:

  "dependencies": {
    "mongodb": "1.3.19"
  },

You can look at other projects for examples. I.E. when I npm install mongoose I don't have to install all of its deps manually, they are pulled dynamically as they are listed in the dependencies section.

from mongo-migrate.

Vadorequest avatar Vadorequest commented on July 17, 2024

That's true. Obvious, but true.

from mongo-migrate.

jmar777 avatar jmar777 commented on July 17, 2024

+1 for adding the mongodb dependency.

  • It's the only sane way I can think of to avoid version compatibility issues between what mongo-migrate needs and what the application itself is using.
  • Also, one could in theory be using Node and mongo-migrate just for migrations, and may not even have a larger Node-based project where mongodb is already required.
  • Lastly, it's more inline with Node dependency conventions to include the mongodb dependency here, since the module itself does indeed depend on it.

from mongo-migrate.

newmanw avatar newmanw commented on July 17, 2024

Is mongodb going to be added a dependency? This really should be done.

from mongo-migrate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.