Comments (5)
You have to install mongodb separately from mongo-migrate... Mongo-migrate just uses mongodb libraries to querying the database
from mongo-migrate.
Sure but if mongo-mongrate (npm) is dependent on mongodb (npm) then it should pull it automatically. I should not have to do npm install mongo-migrate and npm install mongodb. Your module should work out of the box by specifying the dependencies in the package.json.
You specify the mongodb dependency but as a dev dependency:
"devDependencies": {
"mongodb": "1.3.19"
},
This means when I do npm install mongo-migrate, that mongodb 1.3.19 is not pulled in as a dependent module. It is dependent your module will not run without it.
Consider:
"dependencies": {
"mongodb": "1.3.19"
},
You can look at other projects for examples. I.E. when I npm install mongoose I don't have to install all of its deps manually, they are pulled dynamically as they are listed in the dependencies section.
from mongo-migrate.
That's true. Obvious, but true.
from mongo-migrate.
+1 for adding the mongodb dependency.
- It's the only sane way I can think of to avoid version compatibility issues between what mongo-migrate needs and what the application itself is using.
- Also, one could in theory be using Node and mongo-migrate just for migrations, and may not even have a larger Node-based project where mongodb is already required.
- Lastly, it's more inline with Node dependency conventions to include the mongodb dependency here, since the module itself does indeed depend on it.
from mongo-migrate.
Is mongodb going to be added a dependency? This really should be done.
from mongo-migrate.
Related Issues (20)
- Dry run HOT 1
- verror is not defined HOT 4
- migrate on heroku (and mongoLab) HOT 2
- Please push 1.2.1 to npm HOT 1
- Replica sets in mongodb > 2.0 HOT 4
- The command name is `mongo-migrate`, not `node mongodb-migrate` HOT 2
- Error: collection name must be a String HOT 1
- Ignore subdirectories when looking for migrations
- requiring mongodb in migrations HOT 1
- Bin do not work because of windows line ending format HOT 1
- Migration is only updating first record in a collection HOT 1
- Collection Undefined on a Simple Migration HOT 3
- Support for ssl connections
- Migration method "run()", pass revision number
- TypeError: db.Collection is not a function HOT 1
- Change default hard-coded collection to user input to track migrations
- Can't launch migrations inside Docker
- Is project still maintained?
- change of value is NOT working
- Maintenance issue advisories/1203
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mongo-migrate.