Giter VIP home page Giter VIP logo

Comments (7)

go2sh avatar go2sh commented on July 22, 2024

I also can confirm the bug. It seems, that its related to the icon-xlg class. If you change it to icon-md every thing is fine.

from jenkins-material-theme.

nfalco79 avatar nfalco79 commented on July 22, 2024

This issue should be moved to core-theme project.
I have no issue using this them (ensure you are using the correct url in instead neo-theme).
This is the sidebar
desktop
This is the jenkins->menu
menu

from jenkins-material-theme.

cyotek avatar cyotek commented on July 22, 2024

I am using the correct URL - http://jenkins-contrib-themes.github.io/jenkins-material-theme/dist/material-light.css, although as I noted, that doesn't seem to be a bug with the theme (as it can't influence the wrong class names and size attributes). I reported it here as well simply because there was a discrepancy in sizes when using themed versus unthemed and I was curious as to if there was something the theme could override to correct.

As for "core-theme", I wasn't aware this theme was linked to something else, I assumed it was stand alone.

However, I just tested the Neo theme too and observed the same behaviour as with this theme, i.e. a big credentials icon.

from jenkins-material-theme.

afonsof avatar afonsof commented on July 22, 2024

@cyotek the icon is right sized for me too. That's weird. This is my icon html:
<img style="width: 24px; height: 24px; margin: 2px;" alt="" src="/static/f72481f6/plugin/credentials/images/48x48/credentials.png">

Could you check what's your credentials version? Mine is 1.2.4.

from jenkins-material-theme.

cyotek avatar cyotek commented on July 22, 2024

It's 1.2.5, this issue happened after upgrading from 1.2.4 - perhaps I should have been slightly more specific in my initial description rather than just "upgrading core plugins".

When I first found this issue, I reverted back to 1.2.4 and confirmed the issue wasn't present, but as soon as I upgraded back to the latest version the issue was back. I've left the latest version installed as... well, it's the latest version :)

from jenkins-material-theme.

afonsof avatar afonsof commented on July 22, 2024

Anyway I hope I've fixed any kind of anomaly.

from jenkins-material-theme.

cyotek avatar cyotek commented on July 22, 2024

Seems to be working great with v1.2 of the theme, thanks :)

from jenkins-material-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.