false by default. When set to true it inserts the hidden vr-

Add expand attribute to vr-template about aframe HOT 2 CLOSED

aframevr commented on May 12, 2024

Add expand attribute to vr-template

from aframe.

Comments (2)

cvan commented on May 12, 2024

We ought to allow composed DOM subtrees to be toggled via a subtree attribute/component.

<vr-scene>
  <vr-box color="green" position="0 2 0" rotation="-45 45 0"></vr-box>
</vr-scene>

<vr-element name="vr-box">
  <template>
    <vr-object mixin="cube" position="${position}" rotation="${rotation}" material="color: ${color}"></vr-object>
  </template>
</vr-element>

results in this composed (rendered) DOM:

<vr-scene>
  <vr-box color="green">
    <vr-object mixin="cube"  position="0 2 0" rotation="-45 45 0" color="green"></vr-object>
  </vr-box>
</vr-scene>

<vr-element name="vr-box">
  <template>
    <vr-object mixin="cube" position="${position}" rotation="${rotation}" material="color: ${color}"></vr-object>
  </template>
</vr-element>

with shadow DOM, it could be:

<vr-scene>
  <vr-box color="green">
  </vr-box>
</vr-scene>

<vr-element name="vr-box">
  <template>
    <vr-object mixin="cube" position="${position}" rotation="${rotation}" material="color: ${color}"></vr-object>
  </template>
</vr-element>

this bug is to toggle the subtree not to use shadow DOM (which requires quite a hefty polyfill for non-Chrome browsers):

<vr-scene>
  <vr-box color="green" subtree="false"></vr-box>
</vr-scene>

<vr-element name="vr-box">
  <template>
    <vr-object mixin="cube" position="${position}" rotation="${rotation}" material="color: ${color}"></vr-object>
  </template>
</vr-element>

compared with the following:

<vr-scene>
  <vr-box color="green" subtree="true">
    <vr-object mixin="cube"  position="0 2 0" rotation="-45 45 0" color="green"></vr-object>
  </vr-box>
</vr-scene>

<vr-element name="vr-box">
  <template>
    <vr-object mixin="cube" position="${position}" rotation="${rotation}" material="color: ${color}"></vr-object>
  </template>
</vr-element>