Comments (8)
Seems might be due to Vision Pro displays being p3. Might need some spec work. Found relevant convo.
from aframe.
Thanks. I've been told Apple team is aware of it and working on it. I think timeline depends whether it requires modifying the WebXR spec or not.
from aframe.
Additional context https://twitter.com/Cody_J_Bennett/status/1753882034588537117
from aframe.
This is annoying. In theory all we'd have to do is set outputEncoding = THREE.LinearSRGBColorSpace
on the WebXR render target. However, this isn't the case for all pre-existing supported devices, meaning:
- A check is needed to determine if the device is an AVP or not, and depending on it set the output encoding
- Shaders like the ones in aframe-environment-component won't output the correct colours on AVP (= requires changes)
- Projects that require
colorManagement: false
will have incorrect colours on AVP - Projects stuck/still on older A-Frame versions will have incorrect colours on AVP
Not to mention, that if Apple changes it to be in line with the other implementations (or vice versa), any workarounds already in place will instead cause incorrect colours. Not sure what the best approach going forward is, but since WebXR is still behind a flag on AVP, I think an opt-in property or something would be safest, until it's clear if this behaviour is intended or not.
from aframe.
Short term hack might be necessary:
A check is needed to determine if the device is an AVP or not, and depending on it set the output encoding
from aframe.
@dmarcos any updates on a fix for this? I had tried manually adding a gamma correction in a shader and it helped a little but wasn't great :s It's making our splats look sad in https://github.com/mkkellogg/GaussianSplats3D
@mkkellogg FYI
from aframe.
@dlazares This has to be fixed at the Safari / WebXR spec level not A-Frame
from aframe.
thanks @dmarcos, tracking is here https://bugs.webkit.org/show_bug.cgi?id=270465 and also a short-term hack described in it as well.
from aframe.
Related Issues (20)
- 2w- HOT 1
- xr-mode-ui: Add explicit full screen mode HOT 8
- Video playback stops when entering immersive mode in Vision Pro HOT 21
- <a-scene> accessing my webcam HOT 4
- Hiding VR mode UI not working in 1.5.0 HOT 2
- a-videosphere: 180 degree support and SBS support. HOT 2
- Component/attribute inheritance and precedence for primitives HOT 5
- ar hit test can only place once,but i need it can place many times HOT 1
- Updating reflection not possible when using postprocessing HOT 2
- Sudden increase in GPU load when using postprocessing HOT 3
- Utils device isIOS and isMobile checks fail on iPad Pro 12.9 Safari HOT 5
- oob-collider not setting el.object3D as default HOT 16
- Add documentation for before/after API
- Duplicate pinch events on the Quest Pro HOT 3
- OBB isn't centered (includes proposed fix) HOT 6
- Support for transient input on Vision Pro HOT 1
- a-scene Chrome non-passive violation warnings for touchmove and touchstart event handlers HOT 5
- GLB frosted glass material only marginally affect primitives, doens't affect <a-text> or <a-image> HOT 3
- hand-tracking-controls component detaches children (+fix & ideas) HOT 2
- Loading Insta360 Videos HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aframe.