Giter VIP home page Giter VIP logo

Comments (8)

dmarcos avatar dmarcos commented on May 26, 2024 1

Seems might be due to Vision Pro displays being p3. Might need some spec work. Found relevant convo.

from aframe.

dmarcos avatar dmarcos commented on May 26, 2024 1

Thanks. I've been told Apple team is aware of it and working on it. I think timeline depends whether it requires modifying the WebXR spec or not.

from aframe.

dmarcos avatar dmarcos commented on May 26, 2024

Additional context https://twitter.com/Cody_J_Bennett/status/1753882034588537117

from aframe.

mrxz avatar mrxz commented on May 26, 2024

This is annoying. In theory all we'd have to do is set outputEncoding = THREE.LinearSRGBColorSpace on the WebXR render target. However, this isn't the case for all pre-existing supported devices, meaning:

  • A check is needed to determine if the device is an AVP or not, and depending on it set the output encoding
  • Shaders like the ones in aframe-environment-component won't output the correct colours on AVP (= requires changes)
  • Projects that require colorManagement: false will have incorrect colours on AVP
  • Projects stuck/still on older A-Frame versions will have incorrect colours on AVP

Not to mention, that if Apple changes it to be in line with the other implementations (or vice versa), any workarounds already in place will instead cause incorrect colours. Not sure what the best approach going forward is, but since WebXR is still behind a flag on AVP, I think an opt-in property or something would be safest, until it's clear if this behaviour is intended or not.

from aframe.

dmarcos avatar dmarcos commented on May 26, 2024

Short term hack might be necessary:

A check is needed to determine if the device is an AVP or not, and depending on it set the output encoding

from aframe.

dlazares avatar dlazares commented on May 26, 2024

@dmarcos any updates on a fix for this? I had tried manually adding a gamma correction in a shader and it helped a little but wasn't great :s It's making our splats look sad in https://github.com/mkkellogg/GaussianSplats3D

@mkkellogg FYI

from aframe.

dmarcos avatar dmarcos commented on May 26, 2024

@dlazares This has to be fixed at the Safari / WebXR spec level not A-Frame

from aframe.

dlazares avatar dlazares commented on May 26, 2024

thanks @dmarcos, tracking is here https://bugs.webkit.org/show_bug.cgi?id=270465 and also a short-term hack described in it as well.

from aframe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.