Giter VIP home page Giter VIP logo

Comments (5)

teddychan avatar teddychan commented on May 27, 2024

I just run the test.
I think the expect result should be like this:

phone('+1905-555-1234', '')
[ '+19055551234', 'CAN' ]

As 905 is a CAN prefix, not USA.
if you didn't provide +1, as the country prefix, it will treat it as USA, and 905 is NOT USA, so it give you empty.

May be we should do one more improvement, if USA is not match, we should try USA

from phone.

typpo avatar typpo commented on May 27, 2024

Also experiencing this with area code 819. This library behaves incorrectly with Canadian phone numbers that have country code 1.

from phone.

joaoritter avatar joaoritter commented on May 27, 2024

Can you make CAN and USA be treated the same, regardless of the +1? It doesnt make sense for canadian users to have to type +1, but not US users. Thanks!

from phone.

danawoodman avatar danawoodman commented on May 27, 2024

Same issue:

phone("866-454-8855") // []
phone("+1-866-454-8855") // []

from phone.

Bossa573 avatar Bossa573 commented on May 27, 2024

version 2.3.11 resolved this issue by adding CAN as default country together with USA, thanks for the information

from phone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.