Comments (3)
If you provide the 2nd parameter (country), no need to add the +
sign for the phone number.
var phone = require('phone');
phone("+33643123123", "FRA"); // [ '+33643123123', 'FRA' ]
phone("33643123123", "FRA"); // [ '+33643123123', 'FRA' ]
phone("643123123", "FR"); // [ '+33643123123', 'FRA' ]
from phone.
Hi @adamliuxy ,
Does it mean once the plus sign is provided then the program itself would look for a country code prefix?
Let say by typing a HKG mobile ("+852 9122 5454", "HKG")
would consider to be valid cuz plus sign is provided then it look for (852) and decide it's HKG cell phone number. But on the other case when user type ("+ 9122 5454", "HKG")
it would consider to be invalid cuz country number (852) prefix is not provided?
And base on this should fill the number prefix on output if the country short form is provided?
Old case: ("+ 9122 5454", "HKG")
-> Invalid
New case: ("+ 9122 5454", "HKG")
-> Oh prefix (852) is absent but "HKG" is on -> Return ['+85291225454', 'HKG'] for output?
from phone.
@HiuKwok If a phone number is prefixed with a plus sign, it should be considered as there should be a country code provided i.e. for +91225454, the library should try to look up the country code 9
, 91
and so on, and eventually no result could be found.
The country iso3 parameter provides extra information for formatting the phone number, but if the library adds the country code prefix according to the country iso3, ignoring the +
sign, it is distorting the meaning of "the digits come after the plus sign", which supposedly should be followed by country code.
And for @hikkyu cases, please do not add the +
sign before the phone number if you are not sure the digit followed by the +
sign is the country code.
Thanks for the information and contribution, please reopen the ticket if needed
from phone.
Related Issues (20)
- New Canada area codes from 2020 onwards are missing HOT 1
- `phone('+441471323991').isValid` returns false? HOT 1
- Any plan on supporting landline phone number? HOT 1
- Nigerian numbers are up to 11 digits long but the lib assumes they should be 10 digits HOT 3
- Does not correctly parse Zimbabwe numbers +263 HOT 8
- Chinese cell phone numbers will be recognized as US cell phone numbers HOT 4
- Issue with Bahrain country code HOT 3
- Does Not Validate A Valid Phone Number HOT 1
- Library incorrectly flagging UAE phone numbers as incorrect HOT 8
- Missing Angullia 2642, 2644 area code
- Library does not recognise Swaziland Country Code +268 HOT 8
- Error in validating indian phone number with 11 digits HOT 2
- [Phone number format] Add more Poland prefix phone number HOT 5
- Phone Number Output HOT 1
- Some valid phone number is getting as invalid phone numbers HOT 3
- [Phone number format] HOT 1
- Can not validate India phone number HOT 2
- [feature] provide formatted number HOT 1
- [Phone number format]
- Publish only distribution files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phone.