Wrong valdiation of string? about phone HOT 8 CLOSED

Hi, can you provide the sample code?

from phone.

Hi... I am using this.

const getPhone = require('phone') 
function parsePhone (phone) {return  getPhone(phone)[0] }       // getPhone() gives ['+18175698900', 'USA']
function isValidPhone (phone) { return parsePhone(phone) && parsePhone(phone).length > 6  }
let valid = isValidPhone('+31654123456')  // true
let valid = isValidPhone('hallo.key')  // true

I suppose my isValid code is not valid?

from phone.

When I run your code, I got this error,

function isValidPhone (phone) { return parsePhone(phone).length > 6  }
                                                        ^
TypeError: Cannot read property 'length' of undefined

The code I executed (package version 1.0.9):

'use strict';
const getPhone = require('phone') 
function parsePhone (phone) {return  getPhone(phone)[0] }       // getPhone() gives ['+18175698900', 'USA']
function isValidPhone (phone) { return parsePhone(phone).length > 6  }
//let valid = isValidPhone('+31654123456')  // true
let valid = isValidPhone('hallo.key')  

The reason maybe: getPhone('hallo.key') will return empty array, and you try to get the first element from an empty array, so parsePhone(phone) will return undefined.

Please check your code.

from phone.

Sorry, I rewrote my code for you, to make it more clear as the original is part of a larger method. Now updated above... and I had a small bug in my own code... So shame "hallo.key" indeed does not accept

Question remains: do I validate the number correctly now ? I might be missing something, but what to do to just get isValid(phonenr) ?

(and thank you for your great fast response :) )

from phone.

Actually, this package doesn't validate if the number is mobile or not. It's used to normalize the mobile phone number into a E.164 format. You can read the README.md for more information.

from phone.

I understand. But you think it is bad practice to consider it validated if parsing returned a non-empty array?

from phone.

For the existing code, I think it's bad practice. Especially, for this part parsePhone(phone).length > 6, you should ensure parsePhone(phone) have the property .length, otherwise the code will throw error.

from phone.

ok. thank you for your help. Validation is crucial and your code helped to get it going :)

from phone.