Is it possible to give a number and a MCC instead of the country letters? about phone HOT 5 CLOSED

You may use other module, like country-data to convert those code to iso 3166 alpha3.

In addition, I guess the MCC list is NOT valid.
at least I found one problem:

"454": {
588     "full": "Hongkong, China",
589     "code": "hk",
590     "prefix": "+82"
591   },

HK prefix should be "+852"

from phone.

I didn't changed other data like country codes in my PR I've just added MCC_codes. Why would you force us to fork your project rather than contributing to it?

I am open to review but please don't close PRs like so until you've discussed it and people making it understood the reasons why you choose not to consider it.
It is an open source project isn't it? I spent a bunch of time doing it, I opened a ticket ways before the PR so you had time to discuss how you wanted the thing.

MCC are a standard for mobile phone numbers this PR only adds two useful features:

• let the use make a use of the all iso database
• let the user map phones with MCC

It didn't know country-database but why doesn't this project use country-database as a dependency rather than having a blob of json no-sql database at the beginning of the file ?

Don't worry if you don't have time for this just say it and don't worry anymore.

from phone.

Thanks for your contribution.
Let me think again if we should merge your code to our main branch.

from phone.

I think this would be great as well. Specially because I imagine in a lot of cases you have the numerical code rather than country abbreviation.

from phone.

MCC lookup should not be the purpose of this library, will close this issue

from phone.