Cameroon flag breaks when used inside tablesort tables about flags HOT 7 CLOSED

I'll leave the script I've used to generate unique ids here in case lipis/flag-icons will not be interested in PR.

<?php

$files = new RecursiveIteratorIterator(
    new RecursiveDirectoryIterator(
        'svg',
        FilesystemIterator::SKIP_DOTS
    )
);

$rules = [
    '/ id="([a-z])"/' => ' id="{CODE}-$1"',
    '/ xlink:href="#([a-z])"/' => ' xlink:href="#{CODE}-$1"',
    '/"url\(#([a-z])\)"/' => '"url(#{CODE}-$1)"',
];

foreach ($files as $file) {
    $code = $file->getBasename('.svg');
    $fileObj = $file->openFile('r+');
    $contents = $fileObj->fread($file->getSize());

    $compiledRules = [];
    foreach ($rules as $key => $value) {
        $compiledRules[$key] = str_replace('{CODE}', $code, $value);
    }

    $contents = preg_replace(
        array_keys($compiledRules),
        array_values($compiledRules),
        $contents
    );

    $fileObj->rewind();
    $fileObj->fwrite($contents);
}

from flags.

Just tagged the new release with updated icons. Try to update, maybe new icons will fix the issue.

from flags.

Nope, problem remains after updating to v1.0.6, unfortunately.

Cameroon's flag normally:

Cameroon's flag after changing sort order of the table:

Hovering over the <g fill="#fcd116" [...]> element when flag is as intended:

Hovering over the <g fill="#fcd116" [...]> element when flag is in broken state:

from flags.

I was able to reproduce similar issue at codepen. Looks like an issue caused by duplicated ids in these flags.

Codepen with sortable table: https://codepen.io/vovayatsyuk/pen/eYrPXgW?editors=1000

1. At the initial page load, the Honduras flag is corrupted.
2. When changing sort order by clicking on the table header Cameroon and Indian flags get corrupted.

from flags.

I've updated codepen with additional table where I've added -COUNTRY_CODE suffix to all ids.

Here is a result:

@lipis have you ever noticed such behaviour?

from flags.

Good catch, I totally missed that one, but it makes a lot of sense in the context.

from flags.

I've just tagged the new release. The issue should be fixed now.

from flags.