Comments (11)
nealoke
commented on July 19, 2024
1
When trying to reschedule a job in the UI you will get a 404 indeed. Quite blocking :(
from agendash.
Nefsen402
commented on July 19, 2024
Hmm, it looks like anything both requeing or deleting jobs are affected. I drilled down into the issue, and it looks like the pkFactory is not a function anymore, but instead an object with an additional createPk function as a property. Agendash is assuming that pkFactory is a function and failing whenever it tries to modify or delete a job.
agendash/lib/controllers/agendash.js
Line 312 in bbb133f
agendash/lib/controllers/agendash.js
Line 289 in bbb133f
Here are the two references to the broken function.
Edit: I am having this issue with version 4.1.3 of Agenda which you mentioned was ok...
Edit again: No, I'm just jumping the gun, I was looking at package.json instead of package-lock.json. It indeed works on both versions you mentioned.
from agendash.
VadymKultenkoDarth
commented on July 19, 2024
Same here error 404 not found.
TypeError: collection.s.pkFactory is not a function
from agendash.
ljacho
commented on July 19, 2024
It doesn't work
Hmm, it looks like anything both requeing or deleting jobs are affected. I drilled down into the issue, and it looks like the
pkFactoryis not a function anymore, but instead an object with an additionalcreatePkfunction as a property. Agendash is assuming thatpkFactoryis a function and failing whenever it tries to modify or delete a job.agendash/lib/controllers/agendash.js
Line 312 in bbb133f
agendash/lib/controllers/agendash.js
Line 289 in bbb133f
Here are the two references to the broken function.
Edit: I am having this issue with version 4.1.3 of Agenda which you mentioned was ok...
Edit again: No, I'm just jumping the gun, I was looking atpackage.jsoninstead ofpackage-lock.json. It indeed works on both versions you mentioned.
can you confirm it works for you with older versions please?
from agendash.
ljacho
commented on July 19, 2024
Agenda is using new mongodb driver now, see ObjectId
fix: #193
from agendash.
Shahor
commented on July 19, 2024
Is there anything planned to make this move forward?
from agendash.
Shahor
commented on July 19, 2024
@santiq Sorry for pinging you directly but you seem to be the most active contributor.
Can you help on this maybe?
from agendash.
GimpMaster
commented on July 19, 2024
Noticing this issue now. Following to see if it ever gets fixed. Otherwise Agendash is effectively a read-only tool now.
from agendash.
scottbasgaard
commented on July 19, 2024
Same here.
from agendash.
VadymKultenkoDarth
commented on July 19, 2024
what I did was just updated agendahs.js in Controller folder with these
line 3
const { ObjectId } = require("mongodb");
line 45
preMatch[options.property] = ObjectId
(
options.query
);
line 289
_id: { $in: jobIds.map((jobId) => ObjectId(jobId)) },
line 312
_id: { $in: jobIds.map((jobId) => ObjectId(jobId)) },
…________________________________
From: Scott Basgaard ***@***.***>
Sent: Monday, January 24, 2022 5:08 PM
To: agenda/agendash ***@***.***>
Cc: Vadym Kultenko ***@***.***>; Comment ***@***.***>
Subject: Re: [agenda/agendash] [Bug] Agenda 4.2.1 produces an error on Agendash when rescheduling a job (#191)
Same here.
—
Reply to this email directly, view it on GitHub<#191 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHZX2W4TC7CUGJXZTW67CU3UXXLXXANCNFSM5CAXUDPQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID: ***@***.***>
from agendash.
koresar
commented on July 19, 2024
Merged the PR. Expect v3.0.0 soon.
from agendash.
Related Issues (20)
- Why are these jobs still marked as "running"? HOT 3
- Agendash not loading properly HOT 1
- Cant delete schedule HOT 4
- Invalid date is showed on completed jobs HOT 1
- Suggestion: Support setting repeatTimezone when scheduling a job HOT 1
- Mongodb latest version problem HOT 1
- Does the "Refresh Interval" really work? HOT 4
- Can't connect to MongoDB Atlas anymore HOT 4
- Support for ARM64 docker images and v3 HOT 2
- Readonly mode HOT 1
- Is this repo maintained? HOT 2
- Error 404 for "api/jobs/requeue" and "api/jobs/delete" HOT 5
- not working with express HOT 3
- Typescript types
- How to support Typescript language?
- Multiple job deletion button is not working when have more jobs
- Not working with fastify + prefix HOT 2
- Error "QueryExceededMemoryLimitNoDiskUseAllowed" with V4.0 HOT 2
- Error: CDN files for popper and vue etc not found
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from agendash.