Comments (6)
Have you seen this pull request? gavrix@4bd09ed
Also, we know that the resampling could be improved (#23). Currently we are using nearest neighbor which results in a bit more pixelated images than necessary.
from aggeometrykit.
Nope. But I've made almost the same changes in the code. It's good for development purposes, however due to company policy I just can not use pods with my modifications. Any chance to see an updated version with that fix any time soon?
As for resampling it is not an issue for me but it's good to know you're working on it!
P.S.: btw, AGGeometryKit is awesome!
from aggeometrykit.
^ ^, That's a good company policy. I support that! You don't want changes like that discarded on each pod install
.
That pull request is live on master
and published as version 1.2.3
. A pod update
should normally be enough.
We're sadly not working on improving the resampling. I don't have time for that, but I hope others would like to contribute on that part. It will be very interesting, fun and educational.
from aggeometrykit.
Ahhh, man. I just needed to update the pod. I was using 1.2.2. Sorry for wasting your time!
Thanks!
I've just noticed an issue with UIImage scale and "imageWithPerspectiveCorrectionFromQuad". If I pass an image with scale factor 3.0f (iPhone6 Plus) it crops only portion of an image. As far as I traced the rects it appears to act weird here:
(Line 164:) UIImage *correctedImage = [self imageWithTransform:transform anchorPoint:CGPointZero];
(Line 165:) UIImage *resultImage = [correctedImage imageByCroppingToRect:destinationRect];
Here, imageWithTransform returns an image with scale 1.0f (so its size in points = size in pixels) and destinationRect is still in points. So the result image is 1/3 upper part of the source image.
Is this something you're aware of and I'm wasting your time again?
from aggeometrykit.
No problem! :) 1.2.3 was released very recently – good timing.
I'm not aware of this. A pull request on the scale issues would be highly appreciated.
from aggeometrykit.
And also perfect if you can open a separate issue for that.
from aggeometrykit.
Related Issues (20)
- Better resampling of images with AGKTransformPixelMapper HOT 5
- Possible to perspective-distort an image? HOT 17
- Linker errors building Demo HOT 6
- Anti-aliasing approaches HOT 8
- Transformation not applied? HOT 4
- imageWithPerspectiveCorrectionFromQuad scale problem. HOT 7
- Repo moved
- macos support? HOT 2
- Multiple Drag points + Video HOT 5
- Auto-layout HOT 4
- How can I crop the image by using AGGeometryKit. HOT 2
- Rotate around point and scale HOT 3
- Missing AGGeometryKitTests.m HOT 2
- Hello, when i set quadrilateral, the position of the layer is shifted, and how to remove the quadrilateral settings HOT 11
- tvOS HOT 4
- Memory leak in imageByCroppingToRect HOT 3
- Memory leaks HOT 2
- How can I get the final result as UIView or UIImageView
- Is it possible to straighten all the lines?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aggeometrykit.