Tests flake when a callback is called after the test finishes about wasmbrowsertest HOT 11 CLOSED

I haven't had a chance yet but will try to get to it soon. Try just making a test that fires a callback in 10ms and then end the test successfully after 9ms. Should work if the callback fires just after the test ends.

from wasmbrowsertest.

Thanks, do you have a reproducer by any chance that I can use?

from wasmbrowsertest.

I will try to put one together. In this case I believe the code had run some IndexedDB queries with https://github.com/aperturerobotics/go-indexeddb and then the onsuccess callback was being called after the program had exited.

A possible test case would be to spam callbacks to the Go runtime and then succeed the test. The callback should be able to fire and call into Go wasm (which causes an error in the browser as well) just after the test exits, reproducing the issue.

from wasmbrowsertest.

@paralin - Just checking if you were able to find some time on this?

from wasmbrowsertest.

CI failure examples of this issue:

• https://github.com/aperturerobotics/util/actions/runs/9881287652/job/27291736799#step:14:282
• https://github.com/aperturerobotics/bifrost/actions/runs/9881375168/job/27292026324#step:14:1214

from wasmbrowsertest.

I've seen the same issue.

http://127.0.0.1:35499/wasm_exec.js:535:10 Uncaught
Error: Go program has already exited
    at globalThis.Go._resume (http://127.0.0.1:35499/wasm_exec.js:536:11)
    at http://127.0.0.1:35499/wasm_exec.js:264:14
context canceled

https://github.com/hajimehoshi/ebiten/actions/runs/9927011041/job/27421409861

from wasmbrowsertest.

Thanks Hajime san. This is on my mind. Work has been a bit busy these days.

from wasmbrowsertest.

We can mitigate the issue by adding a sleep like this:

func TestMain(m *testing.M) {
	code := m.Run()
	time.Sleep(100 * time.Millisecond)
	os.Exit(code)
}

from wasmbrowsertest.

@hajimehoshi @paralin - I am trying with this:

func TestCallback(t *testing.T) {
	js.Global().Call("setTimeout", js.FuncOf(func(js.Value, []js.Value) interface{} {
		t.Log("hey there")
		return nil
	}), 1000)
	t.Log("done")
}

but unable to reproduce the issue. What am I doing wrong?

from wasmbrowsertest.

Aha nvm, I am able to repro now. The thing is that the timeout needs to fire between the small window when the test has exited, but the browser hasn't yet unloaded.

Repro case:

func TestCallback(t *testing.T) {
	js.Global().Call("setInterval", js.FuncOf(func(js.Value, []js.Value) interface{} {
		t.Log("hey there")
		return nil
	}), 5)

	t.Log("done")
}

from wasmbrowsertest.

Thanks!

from wasmbrowsertest.