Support or workaround for dark themes about jupyterlab-markup HOT 4 OPEN

Whilst I think theme awareness would be a good feature, see also the dark theme : https://mermaid-js.github.io/mermaid/#/./theming?id=theme-variables-reference-table

from jupyterlab-markup.

I found a workable solution by altering the background color of a section.

I'll close the issue as this works for me.

from jupyterlab-markup.

I don't think the problem i solved. Please re-open it.

I tried by adding some CSS, I could manage to filter out a non light-theme by using CSS attribute selector, but think the .jp-RenderedMarkdown selector is too broad.

body[data-jp-theme-light="false"] .jp-RenderedMarkdown img{
	background: red;
}

Can we possible append classes jupyterlab-markup and appropriate svgbob mermaid to rendered SVG's?

If we had those class names we could easy add a backgroundcolor or whatever in https://github.com/agoose77/jupyterlab-markup/blob/master/style/base.css

from jupyterlab-markup.

Just following this up with a TODO @agoose77 -

• We should add a dependency upon IThemeManager so that we can call mermaid.initialize with a dark/light theme.
• Add a configuration option for the dark and light themes

from jupyterlab-markup.