Giter VIP home page Giter VIP logo

Comments (9)

Agranom avatar Agranom commented on August 11, 2024

Hi. I'll think about it right after refactoring )

from ngx-material-timepicker.

jbthomps avatar jbthomps commented on August 11, 2024

For my use case similar to this, it would be helpful to simply be able to edit the underlying input area in a consistent way and have it reflect back in the clock so that users don't necessarily have to go into the clock at all to enter something.

from ngx-material-timepicker.

Agranom avatar Agranom commented on August 11, 2024

already started implementing this feature. I guess it'll be done till the end of this week

from ngx-material-timepicker.

Agranom avatar Agranom commented on August 11, 2024

I implemented the feature. Update to 2.7.0 and look at the demo how to use it. Tell me your opinion about it please

from ngx-material-timepicker.

jbthomps avatar jbthomps commented on August 11, 2024

From what I'm seeing, this looks really close. The only thing that I see that's missing is input restriction (I can type any number of digits into the timepicker), and the ability to tab to AM/PM in the 12 hour clock.

My personal hope would be to have the input field itself that you focus editable when clicking on it, but it is somewhat separate from this original request, and I can raise it as a new issue if it'll make things easier.

from ngx-material-timepicker.

Agranom avatar Agranom commented on August 11, 2024

Yes, make it as a new issue please

from ngx-material-timepicker.

rainbird17 avatar rainbird17 commented on August 11, 2024

I have the same thoughts:

  • Input restriction to valid chars - I can type letters and other characters, it should only allow numbers
  • Input restricted to 2 digits
  • Input restricted to valid time (I should not be able to type 61 minutes, for example)
  • Focus on click - I would prefer the numbers to be focused when first entering edit mode, it makes changing the value easier
  • Add the ability to edit/tab to the AM/PM field so you can use keyboard there too
  • Can we have the arrow keys move the values up/down?

Should I add these to a single new issue? Or append them to jbthomps issue? (not sure if he created it yet)

from ngx-material-timepicker.

Agranom avatar Agranom commented on August 11, 2024

You guys can merge your proposals to one issue, so that I can close this one. Thanks

from ngx-material-timepicker.

rainbird17 avatar rainbird17 commented on August 11, 2024

fyi: I created issue #56 for my enhancement requests....

Thank you so much for implementing this feature!

from ngx-material-timepicker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.