Comments (8)
The management TLS files are also loaded from there...
from pgagroal.
@palak-chaturvedi is working on this
from pgagroal.
v001-Adding_File_Name.patch
I worked on this and made the changes.
I just wanted to know if there is a specific code formatter that I have to run?
from pgagroal.
@fluca1978 @jesperpedersen
https://github.com/palak-chaturvedi/pgagroal/tree/addingFileName
This a branch in my github.
from pgagroal.
@palak-chaturvedi you should create a pull request for this, please.
In the meantime, I took a look at the patch, and while the work is
nice, this cannot be imported. The "master.key" file name is used in
different places around the code, for example in security.c.
Therefore, I would rather not change the filename as you did, but
change the directory where to store the file named 'master.key'. At
glance, the way to go could be to modify pgagroal_get_home to be able
to detect if a different location rather than ~/.pgagroal has to be
used.
from pgagroal.
Ok I will
Can I store the required location in a variable or we need an argument for it?
@fluca1978
from pgagroal.
Ok I will Can I store the required location in a variable or we need an argument for it? @fluca1978
You are free to propose the solution you think is the best, and can also improve it later after a review.
One optimal approach, but longer, could be to introduce a configuration tunable for the location to where store the files.
But let's go with calm and see your idea first.
from pgagroal.
created a pull request.
@fluca1978
#430
from pgagroal.
Related Issues (20)
- `pgagroal-cli` reports wrong (JSON) output when there is a management error HOT 1
- Connection error at the bottom of `status details` HOT 1
- Change `warnx` in `pgagroal-admin` to point at the right file
- Make `pgagroal-admin` provide JSON output HOT 2
- Missing new line in the `pagraoal-admin` help screen
- Improve the `restart_server` function HOT 1
- Improve the `invalid master key file` error HOT 8
- Improve the `pgagroal-admin` command `master-key` to warn users about need for new encryption HOT 1
- Multiple instances can be run if the pid file is specified as a relative path HOT 6
- Fix error message in `pgagroal-admin master-key` HOT 2
- Cannot compile after vault implementation has been merged HOT 5
- Documentation framework HOT 2
- Management protocol documentation HOT 2
- Management protocol incompatibilites due to version numbers HOT 1
- Evaluate and implement full JSON command support HOT 2
- I/O: Replace libev with a native event loop (Linux Support) HOT 1
- pgagroal connections are in Graceful state since a long time HOT 4
- Prometheus: Logging
- pgagroal-admin: SegFault with -P
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pgagroal.