Giter VIP home page Giter VIP logo

Comments (8)

jesperpedersen avatar jesperpedersen commented on August 30, 2024

The management TLS files are also loaded from there...

from pgagroal.

fluca1978 avatar fluca1978 commented on August 30, 2024

@palak-chaturvedi is working on this

from pgagroal.

palak-chaturvedi avatar palak-chaturvedi commented on August 30, 2024

v001-Adding_File_Name.patch
I worked on this and made the changes.
I just wanted to know if there is a specific code formatter that I have to run?

from pgagroal.

palak-chaturvedi avatar palak-chaturvedi commented on August 30, 2024

@fluca1978 @jesperpedersen
https://github.com/palak-chaturvedi/pgagroal/tree/addingFileName

This a branch in my github.

from pgagroal.

fluca1978 avatar fluca1978 commented on August 30, 2024

@palak-chaturvedi you should create a pull request for this, please.
In the meantime, I took a look at the patch, and while the work is
nice, this cannot be imported. The "master.key" file name is used in
different places around the code, for example in security.c.
Therefore, I would rather not change the filename as you did, but
change the directory where to store the file named 'master.key'. At
glance, the way to go could be to modify pgagroal_get_home to be able
to detect if a different location rather than ~/.pgagroal has to be
used.

from pgagroal.

palak-chaturvedi avatar palak-chaturvedi commented on August 30, 2024

Ok I will
Can I store the required location in a variable or we need an argument for it?
@fluca1978

from pgagroal.

fluca1978 avatar fluca1978 commented on August 30, 2024

Ok I will Can I store the required location in a variable or we need an argument for it? @fluca1978

You are free to propose the solution you think is the best, and can also improve it later after a review.
One optimal approach, but longer, could be to introduce a configuration tunable for the location to where store the files.

But let's go with calm and see your idea first.

from pgagroal.

palak-chaturvedi avatar palak-chaturvedi commented on August 30, 2024

created a pull request.
@fluca1978
#430

from pgagroal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.