Giter VIP home page Giter VIP logo

Comments (7)

agronholm avatar agronholm commented on June 2, 2024

asyncio.shield() is an anti-pattern I would very much like to stay away from. I'll get to the bottom of this over Easter.

from anyio.

dominik-schwabe avatar dominik-schwabe commented on June 2, 2024

Understandable. Alternatively one could check if the future got cancled and only raise an error if this is not the case.

self._future.set_result(value)

from anyio.

agronholm avatar agronholm commented on June 2, 2024

Understandable. Alternatively one could check if the future got cancled and only raise an error if this is not the case.

self._future.set_result(value)

Sounds much better already.

from anyio.

dominik-schwabe avatar dominik-schwabe commented on June 2, 2024

I modified my pull request with the alternative solution, but I am not sure if the code on line 628 and 629 should also be executed when the future is cancelled.
https://github.com/dominik-schwabe/anyio/blob/d9179b4750b49ab593c6692e30c8c62f7e295dc4/src/anyio/_backends/_asyncio.py#L619-L629

from anyio.

agronholm avatar agronholm commented on June 2, 2024

No worries, I'll have a look within a couple days.

from anyio.

jonathanslenders avatar jonathanslenders commented on June 2, 2024

Thanks! I just see this thread; having exactly the same issue. :-) Let me know if there's anything I can help with or test.

from anyio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.