Giter VIP home page Giter VIP logo

Comments (7)

agusmakmun avatar agusmakmun commented on September 22, 2024

@tomaszn sounds reasonable, can you please create a PR for this?

from django-markdown-editor.

tomaszn avatar tomaszn commented on September 22, 2024

@agusmakmun Here it is. What about including also Python 3.6 (lowest supported version) in the automated tests matrix?

from django-markdown-editor.

agusmakmun avatar agusmakmun commented on September 22, 2024

@tomaszn, I'm not sure if it will be compatible with the Markdown version or not since we had a collision issue with dependency requirements last time. However, let's test it out in your MR to see if it works or not.

from django-markdown-editor.

tomaszn avatar tomaszn commented on September 22, 2024

@agusmakmun Running tests on Python 3.6 fails on urllib3. Their support ended in 2.0.0 (2023-04-26).

So we can pin urllib3<2 for Python 3.6, or drop it as it already reached End-Of-Life.

from django-markdown-editor.

agusmakmun avatar agusmakmun commented on September 22, 2024

@tomaszn I see, maybe to add prefix as well if it using Python 3.6

from django-markdown-editor.

tomaszn avatar tomaszn commented on September 22, 2024

@agusmakmun You were right, Markdown 3.4 requires Python 3.7.

I locked proper package versions for Python 3.6 and the tests passed. What about merging these changes, releasing the last 1.6 release, and starting 1.7 line:

  • without py3.6 support (and without my compatibility changes)
  • with Markdown 3.4.x

from django-markdown-editor.

agusmakmun avatar agusmakmun commented on September 22, 2024

thanks @tomaszn for creating that PR, I have bumped the newest version, please upgrade it.

from django-markdown-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.