Comments (7)
@tomaszn sounds reasonable, can you please create a PR for this?
from django-markdown-editor.
@agusmakmun Here it is. What about including also Python 3.6 (lowest supported version) in the automated tests matrix?
from django-markdown-editor.
@tomaszn, I'm not sure if it will be compatible with the Markdown version or not since we had a collision issue with dependency requirements last time. However, let's test it out in your MR to see if it works or not.
from django-markdown-editor.
@agusmakmun Running tests on Python 3.6 fails on urllib3
. Their support ended in 2.0.0 (2023-04-26).
So we can pin urllib3<2
for Python 3.6, or drop it as it already reached End-Of-Life.
from django-markdown-editor.
@tomaszn I see, maybe to add prefix as well if it using Python 3.6
from django-markdown-editor.
@agusmakmun You were right, Markdown 3.4 requires Python 3.7.
I locked proper package versions for Python 3.6 and the tests passed. What about merging these changes, releasing the last 1.6 release, and starting 1.7 line:
- without py3.6 support (and without my compatibility changes)
- with Markdown 3.4.x
from django-markdown-editor.
thanks @tomaszn for creating that PR, I have bumped the newest version, please upgrade it.
from django-markdown-editor.
Related Issues (20)
- martor markdownify is vulnerable to stored XSS. HOT 5
- bleach deprecated and NoCssSanitizerWarning: 'style' attribute specified, but css_sanitizer not set error HOT 3
- Incompatibility with Django 4.2 HOT 3
- Dark mode woks not as expected HOT 4
- Error when accessing /admin page in martor_demo container
- After version 1.6.26 the setting MARTOR_UPLOAD_URL is ignored HOT 6
- The editor does not work when setting a Content Security Policy HOT 1
- Loosen restriction on importlib-metadata HOT 4
- Emoji url is done HOT 1
- class tag doesn't render correctly HOT 2
- toolbar nav style issue HOT 1
- Error with markdownify HOT 1
- Adding a new instance in an admin inline results in Uncaught TypeError HOT 1
- Losing text when (semi)colons follow links. HOT 2
- preview is not displaying correctly for “ordered” and “unordered” list items. HOT 1
- 📣 Call for Contributors: Help Needed to Maintain and Enhance django-markdown-editor! HOT 6
- Enable specifying the size of an image HOT 1
- Django 5 & Python 3.12 support HOT 2
- Updating Editor Content with Javascript HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-markdown-editor.