Comments (11)
Ok, apologies for this. The issue has come about due to a change in the underlying images that ComfyUI is inheriting from so builds are currently broken until I push the changes up to ComfyUI but still needs some testing.
The cause is that storage monitor is now being run as a system user (user) so it doesn't have permission to write to the root owned workspace (runpod-volume). An interim fix may be to override the storagemonitor supervisor file to ensure it still runs as root, or change the permissions in the workspace. You should be able to achieve this by running your images in GPU cloud with the volume attached.
Should be resolved by Monday but hopefully earlier.
from comfyui.
Both are bundled in my image. They are useful here but will be used more extensively in an upcoming image I have planned.
If you have no volume mounted you can just chown -R 1000:1000 /runpod-volume. Add it in preflight.sh on layer0. This is a temporary fix - I wouldn't normally suggest it but it may get you running for now.
That's as much help as I can offer currently as I need to test this myself. I'll update when I know more
from comfyui.
The new issue is related. It's all about permissions but fortunately I expect this to be resolved when the update is pushed.
from comfyui.
Source tree has been updated and builds should now work as expected. Base bumped to PyTorch 2.2.0 on nvidia-runtime base image.
from comfyui.
I've noticed recent unusual behaviour with the runpod network volumes. I'm not sure what, if anything, they have changed but I'll investigate and try to work around.
from comfyui.
Im running into the same issue as well. The changes I've made are adding some models/nodes to layer1/init.sh as well as these lines
build_extra_get_models \
"/opt/storage/stable_diffusion/models/ipadapter" \
"${IPADAPTER_MODELS[@]}"
build_extra_get_models \
"/opt/storage/stable_diffusion/models/clip_vision" \
"${CLIP_VISION_MODELS[@]}"
Adding to mappings.sh
storage_map["stable_diffusion/models/ipadapter"]="/opt/ComfyUI/models/ipadapter"
storage_map["stable_diffusion/models/clip"]="/opt/ComfyUI/models/clip"
storage_map["stable_diffusion/models/clip_vision"]="/opt/ComfyUI/models/clip_vision"
Changed the tags/image to my own ghcr repo
version: "3.8"
services:
supervisor:
build:
context: ./build
args:
IMAGE_BASE: ${IMAGE_BASE:-ghcr.io/ai-dock/jupyter-pytorch:2.1.1-py3.10-cuda-11.8.0-base-22.04}
tags:
- "ghcr.io/bkunbargi/comfybrev:jupyter-pytorch:2.1.1-py3.10-cuda-11.8.0-base-22.04"
image: ghcr.io/bkunbargi/comfybrev:jupyter-pytorch:2.1.1-py3.10-cuda-11.8.0-base-22.04
Update: I added a network volume and the issue changed to
[01qu4hfco957dp]
[info]
ln: failed to create symbolic link '/opt/ComfyUI/models/checkpoints/v1-5-pruned-emaonly.ckpt': Permission denied
2024-02-09 15:41:30.091
[01qu4hfco957dp]
[info]
ln: failed to create symbolic link '/opt/ComfyUI/models/controlnet/control_canny-fp16.safetensors': Permission denied
2024-02-09 15:41:30.091
[01qu4hfco957dp]
[info]
ln: failed to create symbolic link '/opt/ComfyUI/models/controlnet/diff_control_sd15_depth_fp16.safetensors': Permission denied
2024-02-09 15:41:30.091
[01qu4hfco957dp]
[info]
mkdir: cannot create directory ‘/opt/ComfyUI/models/ipadapter’: Permission denied```
from comfyui.
Ok, apologies for this. The issue has come about due to a change in the underlying images that ComfyUI is inheriting from so builds are currently broken until I push the changes up to ComfyUI but still needs some testing.
The cause is that storage monitor is now being run as a system user (user) so it doesn't have permission to write to the root owned workspace (runpod-volume). An interim fix may be to override the storagemonitor supervisor file to ensure it still runs as root, or change the permissions in the workspace. You should be able to achieve this by running your images in GPU cloud with the volume attached.
Should be resolved by Monday but hopefully earlier.
I see, thank you for the investigation. I have question. Is storage monitor included in this image(ai-dock/comfyui) or in runpod? And is it same with the inotifywait mentioned in README ? I want to know what are those two.
And I am deploying on runpod serverless, so I can't edit in cloud. Do I need to edit init.sh
?
from comfyui.
Both are bundled in my image. They are useful here but will be used more extensively in an upcoming image I have planned.
If you have no volume mounted you can just chown -R 1000:1000 /runpod-volume. Add it in preflight.sh on layer0. This is a temporary fix - I wouldn't normally suggest it but it may get you running for now.
That's as much help as I can offer currently as I need to test this myself. I'll update when I know more
gotta try.
Thank you so much, I really appreciate for your work🙏
from comfyui.
@hongminpark did it work for you?
from comfyui.
@hongminpark did it work for you?
Nope, so I tried move custom files directly inside Comfy directory at init.sh
function build_extra_start() {
build_extra_get_nodes
//...
# Copy models directly
mv /opt/storage/stable_diffusion/models/ckpt/* /opt/ComfyUI/models/checkpoints
mv /opt/storage/stable_diffusion/models/controlnet/* /opt/ComfyUI/models/controlnet
mv /opt/storage/stable_diffusion/models/embeddings/* /opt/ComfyUI/models/embeddings
}
Then the model files are correctly included but now I'm facing new problem : runpod serverless handler is not responding my api request, I am getting only 'queued' and comfyui isn't getting any request.
from comfyui.
Fixed. Issues relating to permissions are solved by building against the latest PyTorch/Jupyter PyTorch images.
from comfyui.
Related Issues (20)
- Building the docker image fails HOT 5
- [Feature request] small docker image for workspace_sync=true HOT 1
- Comfyui keeps restarting on prompt
- Video2Video on serverless API (Runpod) HOT 1
- Webui force redirects from domain name to public IP HOT 11
- how to download file to docker when it's running? HOT 2
- How to connect to comfyui websocket endpoint HOT 1
- Video outputs HOT 1
- permanent output urls HOT 1
- Send api response to webhook when run fails
- error": "[Errno 2] No such file or directory: '/workspace//ComfyUI/output//image_00001_.png' HOT 8
- Custom nodes, imports fails. Moving mamba env to workspace? HOT 9
- Server not ready after timeout ({timeout}s HOT 6
- mamba-skel not found HOT 1
- Progress updates from RunPod serverless while generating HOT 2
- docker compose build error - run set -eo pipefall && ... HOT 4
- Getting error "value_not_in_list", i.e. checkpoint is not getting loaded somehow. HOT 6
- [HELP with __init__.py] I have the problem with the following Custom Nodes, which when I want to install manually, I get an error
- ComfyUI serverless worker broken after adding new nodes to network volume HOT 5
- endpoint.run not working HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from comfyui.