Giter VIP home page Giter VIP logo

Comments (5)

ai avatar ai commented on July 28, 2024

Because byte could contain number bigger than alphabet length.

For example, if alphabet size i 5 symbols (abcde), nanoid’s random generator will put to byte numbers between 0…7. 0, 1, 2, 3, 4 is correct positions in the alphabet, but 5, 6 will be out of alphabet size.

from nanoid.

davidklebanoff avatar davidklebanoff commented on July 28, 2024

Ah, right. For some of the non-default cases.

On an unrelated note, var byte = bytes[i] & mask caused a brief moment of confusion when I was looking at the code. At quick glance, based on the variable names alone, one might expect a variable named byte would be var byte = bytes[i] rather than var byte = bytes[i] & mask. Not a pressing matter, but I believe there's room for improvement in the variable name to eliminate any confusion. *shrug*

from nanoid.

ai avatar ai commented on July 28, 2024

I am open for name suggestion :D.

& mask reduce cases when we ignore byte when it out of alphabet size (so for 5 symbols alphabet byte = bytes[i] will generate numbers between 0…255, but byte = bytes[i] & mask will generate 0..7)

from nanoid.

davidklebanoff avatar davidklebanoff commented on July 28, 2024

Right.

Something like alphabetIndex might work? It describes its purpose rather than its origin.

from nanoid.

ai avatar ai commented on July 28, 2024

Or maybe position or char?

from nanoid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.