Comments (5)
Because byte
could contain number bigger than alphabet length.
For example, if alphabet size i 5 symbols (abcde
), nanoid’s random generator will put to byte
numbers between 0…7
. 0, 1, 2, 3, 4
is correct positions in the alphabet, but 5, 6
will be out of alphabet size.
from nanoid.
Ah, right. For some of the non-default cases.
On an unrelated note, var byte = bytes[i] & mask
caused a brief moment of confusion when I was looking at the code. At quick glance, based on the variable names alone, one might expect a variable named byte
would be var byte = bytes[i]
rather than var byte = bytes[i] & mask
. Not a pressing matter, but I believe there's room for improvement in the variable name to eliminate any confusion. *shrug*
from nanoid.
I am open for name suggestion :D.
& mask
reduce cases when we ignore byte when it out of alphabet size (so for 5 symbols alphabet byte = bytes[i]
will generate numbers between 0…255
, but byte = bytes[i] & mask
will generate 0..7
)
from nanoid.
Right.
Something like alphabetIndex
might work? It describes its purpose rather than its origin.
from nanoid.
Or maybe position
or char
?
from nanoid.
Related Issues (20)
- Unverified input breaks nanoid HOT 1
- Can't use nanoid@4 with typescript HOT 1
- More intuitive calculator? HOT 1
- Docs: Unnecessary use of --save flag HOT 1
- ulid format preset HOT 1
- Doesn't work with AWS Lambdas
- Question: about the usage of a bitmask
- Error while importing in node js
- Issue while running in Firebase Emulator (Cloud Functions) HOT 1
- Errors with nanoid v3 when using jest and jsdom HOT 13
- Error on nanoid HOT 1
- ERR_REQUIRE_ESM' const { nanoid } = require("nanoid"); HOT 1
- Not working with expo HOT 22
- strange error HOT 2
- Error when calling nanoid in browser (from 5.0.5) HOT 6
- Nothing
- Undefined in Server Side Nextjs / Node HOT 1
- Cannot read properties of undefined (reading 'length') HOT 7
- Move benchmark to tibybench HOT 4
- Is it possible to create a single js file to import in a company inner project? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nanoid.