Giter VIP home page Giter VIP logo

Comments (7)

ai avatar ai commented on July 17, 2024

@size-limit/time is not using on client-side. It is server-side only package.

Are you sure it leads to increasing bundle size? Can you show some project with this issue?

from size-limit.

ad1992 avatar ad1992 commented on July 17, 2024

@size-limit/time is not using on client-side. It is server-side only package.

Are you sure it leads to increasing bundle size? Can you show some project with this issue?

Since size-limit a dev dependency so bundle size eventually won't matter but due to multiple versions of react the host build can break if they are on React 18 specially thats what is happening right now excalidraw/excalidraw#6801

from size-limit.

ai avatar ai commented on July 17, 2024

Hm. The problem is that we can’t use host’s version.

We are using React sources to estimate to CPU power of CI by parsing these sources. React 18 and React 17 has a different size and the result will be different.

But we can switch from React to some another library. Do you know some big library without dependencies?

from size-limit.

ad1992 avatar ad1992 commented on July 17, 2024

parsing these sources

In that case instead of using the npm package for react, you can keep a local copy of its react.production.min.js ? or even use the unpkg link ?
That way host don't have to install react

from size-limit.

ai avatar ai commented on July 17, 2024

Hm, interesting idea. Do you want to send PR to keep your name in the project’s history?

from size-limit.

ad1992 avatar ad1992 commented on July 17, 2024

Sure I will raise a PR shortly

from size-limit.

ad1992 avatar ad1992 commented on July 17, 2024

@ai had been busy so couldn't raise the PR, I have opened a PR and this seems to work fine, let me know

from size-limit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.