Comments (11)
im having the exact same issue trying to use @million/lint. having craco installed on a CRA, following those instructions i get the following error TypeError: MillionCompiler.craco is not a function
on craco.js.
/Users/[...]/craco.config.js:7
plugins: [MillionCompiler.craco({ legacyHmr: true })],
On the other hand million/compiler works as expected.
from million.
Thanks for opening this issue! A maintainer will review it soon.
from million.
Hmm, hello there @philsherry, thank you for reporting this. It would really help me a lot if you provided a reproduction. Do you think you can help with that?
I don't seem to be experiencing the same issues on my end.
from million.
@tobySolutions There are two different sets of installation instructions for the same task, appearing in two different places. Is it safe to assume that there should only be one set of instructions? If so, which of the two is correct? @cloughy gets the same issue that I reported by running the code from one of those sets of instructions.
Can someone please clarify the instructions for installation with craco, and then update the blog or docs to reflect that clarity? Maybe even add a working example with a craco.config.js
?
from million.
Um, thank you very much @philsherry, @cloughy. Craco with Million optimizer seems to be working fine for me with this same config:
const million = require("million/compiler");
module.exports = {
webpack: {
plugins: { add: [million.webpack({ auto: true })] },
},
};
With Million Lint however, there have been cases where people experienced difficulties using Craco to set up Million lintand the team has worked to get that resolved. In the very next and upcoming release, issues like these wouldn't happen again.
Thank you @philsherry, maybe you can help with a reproduction for the cases so I can further investigate. I will begin work on the docs though to help clear out and clarify things on there.
from million.
I'd love to add some context,
const MillionCompiler = require('@million/lint/dist/compiler/craco');
does export something that can't be imported otherwise (without mentioning the dist folder explicitly) which looks like a craco middleware, yet it does not work even if you try to import it.
from million.
@tobySolutions There are two different sets of installation instructions for the same task, appearing in two different places. Is it safe to assume that there should only be one set of instructions? If so, which of the two is correct? @cloughy gets the same issue that I reported by running the code from one of those sets of instructions.
Can someone please clarify the instructions for installation with craco, and then update the blog or docs to reflect that clarity? Maybe even add a working example with a
craco.config.js
?
Hello there @philsherry, sorry for the confusion. Yes, they are two different installations; the first one is for the Million OSS (Million optimizer) and the other is for Million Lint (The Linter).
- Million OSS: https://million.dev/docs/install#install-millionjs
- Million Lint: https://million.dev/blog/lint#install-npm-package
from million.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.
from million.
I still haven't seen any progress in this issue (to be honest, didn't try to install again in case the versions bumped). just commenting to show this is not stale
from million.
I still haven't seen any progress in this issue (to be honest, didn't try to install again in case the versions bumped). just commenting to show this is not stale
Hey there, sorry for the auto-labelling bot. Can you please retry and let me know how that goes? I'll see to it that the team's attention is drawn to this if you still experience the same thing.
from million.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.
from million.
Related Issues (20)
- Lost MiniCssExtractPlugin, do not parse scss files HOT 7
- Provide option to disable intro message in terminal HOT 4
- Error when installing: "ReadableStream is not defined" HOT 6
- Feedback for βInstallationβ - double up on items in right side bar HOT 5
- Breaks React-Dropzone after 3.0.0 update HOT 5
- π Tooling: Stop auto-closing not-actually-stale issues HOT 7
- Spreaded props are lost when combined with explicitly setted props HOT 3
- Error: Invalid hook call. Hooks can only be called inside of the body of a function component. HOT 3
- Lint never connects to VS code HOT 25
- Lint: Better Account Management HOT 3
- "Transforming vite.config.ts" doesn't actually transform anything HOT 3
- Does not work with `react-hook-form` in auto mode HOT 2
- svgs not rendering HOT 4
- Lint broken with Next.js URL rewrites - TypeError: prevRewrites is not iterable HOT 3
- Million lint build error when configuring using webpack (TypeError: Cannot read properties of undefined (reading 'anya')) HOT 3
- π Documentation: Typo in the docs while doing manual installation HOT 2
- React app build failing: `cause: SocketError: other side closed` HOT 2
- Doesn't correctly handle NextJS config function HOT 3
- Failed to lint. Please try again later. HOT 4
- Can't install because of cli-high (requires bun) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from million.