Giter VIP home page Giter VIP logo

Comments (15)

github-actions avatar github-actions commented on May 23, 2024

Thanks for opening this issue! A maintainer will review it soon.

from million.

tobySolutions avatar tobySolutions commented on May 23, 2024

Hello there @Idrinth, do you think you can provide a reproduction that I can have a look at and then present to the team if need be. You shouldn't be getting the above error at all.

from million.

Idrinth avatar Idrinth commented on May 23, 2024

terribly sorry if the example was too big. will put some time aside to build a smaller one tomorroe

from million.

Idrinth avatar Idrinth commented on May 23, 2024

Hello there @Idrinth, do you think you can provide a reproduction that I can have a look at and then present to the team if need be. You shouldn't be getting the above error at all.

https://stackblitz.com/edit/vitejs-vite-azcm9h

from million.

github-actions avatar github-actions commented on May 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

from million.

Idrinth avatar Idrinth commented on May 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

That shouldn't be the case, issue is still unsolved to my knowledge.

from million.

tobySolutions avatar tobySolutions commented on May 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

That shouldn't be the case, issue is still unsolved to my knowledge.

Hmm, thank you very much for this. Really appreciate this. Let me share this with the team. Sorry for the auto-labelling bot.

from million.

tobySolutions avatar tobySolutions commented on May 23, 2024

Taking a look at your reproduction now.

from million.

tobySolutions avatar tobySolutions commented on May 23, 2024

Ok, I fixed it @Idrinth; the issue isn't a Million issue at all. It's an issue with babel and vite I think. So, I did a bit of research around and found a fix:

https://stackblitz.com/edit/vitejs-vite-gm2ltv?file=vite.config.ts

from million.

Idrinth avatar Idrinth commented on May 23, 2024

Ok, I fixed it @Idrinth; the issue isn't a Million issue at all. It's an issue with babel and vite I think. So, I did a bit of research around and found a fix:

https://stackblitz.com/edit/vitejs-vite-gm2ltv?file=vite.config.ts

That is using the deprecated assert instead of with for the import. Can't replicate it working once I switch back to with.

from million.

tobySolutions avatar tobySolutions commented on May 23, 2024

Ok, I fixed it @Idrinth; the issue isn't a Million issue at all. It's an issue with babel and vite I think. So, I did a bit of research around and found a fix:

https://stackblitz.com/edit/vitejs-vite-gm2ltv?file=vite.config.ts

That is using the deprecated assert instead of with for the import. Can't replicate it working once I switch back to with.

Oh yes, you are correct. However this issue has nothing to do with Million.

It still says the same thing when you remove Million from your codebase.

from million.

Idrinth avatar Idrinth commented on May 23, 2024

Ok, I fixed it @Idrinth; the issue isn't a Million issue at all. It's an issue with babel and vite I think. So, I did a bit of research around and found a fix:
https://stackblitz.com/edit/vitejs-vite-gm2ltv?file=vite.config.ts

That is using the deprecated assert instead of with for the import. Can't replicate it working once I switch back to with.

Oh yes, you are correct. However this issue has nothing to do with Million.

It still says the same thing when you remove Million from your codebase.

In that case my small example is insufficient, will try to replicate the issue in something slightly bigger. My main project works without million and only breaks once adding it :(

from million.

Idrinth avatar Idrinth commented on May 23, 2024

more digging and it looks like there is no way on million's side to fix this. Will have to do some code replacements to byopass the vite issue I guess.

from million.

tobySolutions avatar tobySolutions commented on May 23, 2024

Yes @Idrinth, thank you very much πŸ™Œ

from million.

Idrinth avatar Idrinth commented on May 23, 2024

Yes @Idrinth, thank you very much πŸ™Œ

was easier than expected, actually just needed to switch to the babel plugin instead - that worked out fine.

from million.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.