MSVC specific pragma directives about imguifiledialog HOT 10 CLOSED

Thank you! I'll check it out soon.
Suppressing the warning didn't appeal to me at first, especially doing it in the user code, but I think it's still alright.

from imguifiledialog.

I'm warnings free now. :)
Note that #pragma GCC diagnostic ignored "-Wunknown-pragmas" is still in the header file. Either there should be written a temporary comment about those lines, or they should be removed. I suggest the former. And this issue may be closed.

from imguifiledialog.

Hello,
np i take into account all user advices :)
will check that

from imguifiledialog.

its ok now for you ?

from imguifiledialog.

I tried the code with the latest changes and the warnings didn't go away.
First, I think that #pragma GCC diagnostic ignored "-Wpragmas" should have -Wunknown-pragmas instead, but I tried both anyway. The problem instead is that this specific warning might not be controllable by #pragma, i.e. it cannot be changed in any way. I even tried turning it into an error with #pragma GCC diagnostic error <kind> and it didn't work. See https://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Pragmas.html.
It looks like the only option is to suppress this warning from the command line. (This works: -Wno-unknown-pragmas.)

from imguifiledialog.

One solution would be to add something like this in the CMakeLists.txt file of this project:

if(UNIX)
    target_compile_options(ImGuiFileDialog PUBLIC "-Wno-unknown-pragmas")
endif()

And probably instead of UNIX, it should check for a specific compiler:
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")

from imguifiledialog.

ah yes its a solution. i tried "no-unknown-pragmas"' in code and was no effect. but not tested as flags to the compiler.
will test that. i think for unix is enough :)
thanks

from imguifiledialog.

Maybe it's for the same reason why #pragma GCC diagnostic ignored "-Wunknown-pragmas" or #pragma GCC diagnostic error "-Wunknown-pragmas" don't work either.

from imguifiledialog.

i see some issues and pullrequest on gcc and clang repo about these features, who are full of bug. so one day these pragma ignore in code will work. but for now this can work

from imguifiledialog.

thanks for your help :)

from imguifiledialog.