Giter VIP home page Giter VIP logo

Comments (12)

aiekick avatar aiekick commented on May 18, 2024

Hello,

thanks for reported this.

btw not sure if in understand well.

you say, when you double click for open a directory, the frame after, the end of the list is not rendered ?

if this is that its normal.
When you open the dir, ImGuiFileDialog will start to scan the new directory and so empty the current list.
and its happenning during the display, so for avoid unecessary extra code, i decided to break the loop.
so as weel the end of the list is not rendered the next frame, but only the next frame.

is this a problem for you ?

from imguifiledialog.

jvannugteren avatar jvannugteren commented on May 18, 2024

Ok that explains indeed why it happens. It is a problem though, because when I do only a single click (not opening the next directory/file) it also happens. This causes the itemlist to look glitchy every time you click an item.

from imguifiledialog.

jvannugteren avatar jvannugteren commented on May 18, 2024

After your explanation I figured out that it could be avoided by commenting out line #1519 return true; // needToBreakTheloop. Maybe this can be moved inside the if statement which checks for double clicks:

if (ImGui::IsMouseDoubleClicked(0)) // 0 -> left mouse button double click
{
	m_PathClicked = SelectDirectory(vInfos); 
        return true; // needToBreakTheloop
}

from imguifiledialog.

aiekick avatar aiekick commented on May 18, 2024

so the problem for you is the glitch ?

from imguifiledialog.

jvannugteren avatar jvannugteren commented on May 18, 2024

Yes it is only visual. But gets annoying quickly. I can make a merge request of my tiny modification if you like?

from imguifiledialog.

aiekick avatar aiekick commented on May 18, 2024

yes please. your solution is working fine

from imguifiledialog.

jvannugteren avatar jvannugteren commented on May 18, 2024

Ok done. See pull request.

from imguifiledialog.

aiekick avatar aiekick commented on May 18, 2024

thanks you :)

from imguifiledialog.

jvannugteren avatar jvannugteren commented on May 18, 2024

Thanks, problem solved. (=

from imguifiledialog.

jvannugteren avatar jvannugteren commented on May 18, 2024

Unfortunately this issue has resurfaced. It can probably be easily fixed by commenting line 3897 in ImGuiFileDialog.cpp:

// return true; // needToBreakTheloop

Thanks.

from imguifiledialog.

aiekick avatar aiekick commented on May 18, 2024

yes its possible i rewrote it a bit for the new picture system.

thanks

from imguifiledialog.

aiekick avatar aiekick commented on May 18, 2024

fixed ! :)

from imguifiledialog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.