Request Pynacl Encryption Middleware about aiohttp HOT 13 CLOSED

We don't debug third party software, sorry. Take it up with whoever provides you with that library.

from aiohttp.

The report makes it sound like token_auth_middleware is something in aiohttp, but it's not. So, I suspect the issue is reported in the wrong project.

from aiohttp.

I opened a feature request, I proposed one reference implementation for the feature as well. It is request to evaluate implementing this feature in aio_http.

from aiohttp.

It's rather unclear what the request is. You start by describing a problem with some middleware we know nothing about and then just link to some code as the suggested solution.

Please describe the actual feature you want. I don't think we generally have any middlewares included in aiohttp itself, so if the proposal is for a pre-built middleware, I think probably this is not the right place for it.

from aiohttp.

It's rather unclear what the request is. You start by describing a problem with some middleware we know nothing about and then just link to some code as the suggested solution.

Please describe the actual feature you want. I don't think we generally have any middlewares included in aiohttp itself, so if the proposal is for a pre-built middleware, I think probably this is not the right place for it.

The feature is a middleware that works for both websocket and http requests. The middleware is responsible to pick the encrypted message and sender's public key from query parameters, and upon successful decoding to forward the request to the handier regardless if that was a websocket or http request.

from aiohttp.

The feature is a middleware that works for both websocket and http requests.

You mean that you want changes to aiohttp to allow a middleware to work for both websocket/http requests? What currently stops this from working and what changes would be needed?

from aiohttp.

Can you provide a minimal reproducer that demonstrates the issue?

from aiohttp.

The feature is a middleware that works for both websocket and http requests.

You mean that you want changes to aiohttp to allow a middleware to work for both websocket/http requests? What currently stops this from working and what changes would be needed?

I believe there is not need to change aiohttp as the middleware is currently working as is. But in addition to what the middleware does, I would like to forward a cloned request to the handler with the content changed to be the decrypted message which is json (either a string or object). I am not sure which is the correct way to accomplish this using aiohttp though...

from aiohttp.

Can you provide a minimal reproducer that demonstrates the issue?

Sure, let me prepare this.

from aiohttp.

Can you provide a minimal reproducer that demonstrates the issue?

Here is the server side of the minimal reproducer: https://github.com/CosmicDNA/pynacl-middleware-canonical-example. I will start preparing a client minimal reproducer and instructions.

from aiohttp.

Can you provide a minimal reproducer that demonstrates the issue?

Here is the server side of the minimal reproducer: https://github.com/CosmicDNA/pynacl-middleware-canonical-example. I will start preparing a client minimal reproducer and instructions.

I was expecting a single file, probably without any classes. i.e. something comparable to our quickstart example with a middleware added: https://docs.aiohttp.org/en/stable/#server-example

I would like to forward a cloned request to the handler with the content changed to be the decrypted message which is json (either a string or object). I am not sure which is the correct way to accomplish this using aiohttp though...

Without knowing about the details, I'd suggest the middleware could store the decrypted message on the request object (i.e. request["decrypted"] = decrypted_message) and then the handler can use that.

from aiohttp.