Proxy auth proposal about aiohttp HOT 8 CLOSED

I agree, but I'd make separate parameters for login and password

from aiohttp.

But aiohttp.request accepts auth as tuple of (login, password)

from aiohttp.

I think that was wrong decision. I used requests library as an example, but that's wrong

from aiohttp.

We have to be consistent.
If we will use login and password as parameters for Proxy Connector
than we need to support that in aiohttp.request too (as well as in other
places).

On Thu, Jun 26, 2014 at 6:43 PM, Nikolay Kim [email protected]
wrote:

I think that was wrong decision. I used requests library as an example,
but that's wrong

—
Reply to this email directly or view it on GitHub
#84 (comment).

Thanks,
Andrew Svetlov

from aiohttp.

I agree. How about basic_login instead of just login or basic_auth_login—
Sent from Mailbox

On Thu, Jun 26, 2014 at 8:48 AM, Andrew Svetlov [email protected]
wrote:

We have to be consistent.
If we will use login and password as parameters for Proxy Connector
than we need to support that in aiohttp.request too (as well as in other
places).
On Thu, Jun 26, 2014 at 6:43 PM, Nikolay Kim [email protected]
wrote:

I think that was wrong decision. I used requests library as an example,
but that's wrong

—
Reply to this email directly or view it on GitHub
#84 (comment).

Thanks,

Andrew Svetlov

Reply to this email directly or view it on GitHub:
#84 (comment)

from aiohttp.

basic_login and basic_passwd?
Both should be either None or not None

from aiohttp.

Looks good. And proxy_login for proxy—
Sent from Mailbox

On Thu, Jun 26, 2014 at 8:57 AM, Andrew Svetlov [email protected]
wrote:

basic_login and basic_passwd?

Both should be either None or not None

Reply to this email directly or view it on GitHub:
#84 (comment)

from aiohttp.

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

from aiohttp.