Jitterbuffer overflow causing up to 3000 lost frame packets about aiortc HOT 8 CLOSED

Hi, the changes are pretty hard to read could you possibly provide a diff against master?

from aiortc.

Sure - I've just looked at the comment - seems like the markup didn't keep my formatting.

from aiortc.

Also, for my understanding how many packets does a single frame span at most? What kind of resolution are we talking about?

FYI the jitter buffer implementation draws inspiration from pjsip

from aiortc.

rtcrtpreceiver-fix+diff.zip

Attached is a zip of the changed files and the diff from the 0.5.0 tag. Which I assume the release i installed cam from.

For your info the max packet packet count on a 10/20 min run from a 1280x720 camera feed varied between around 40 and 84 packets per frame.

from aiortc.

OK thanks, those are some interesting metrics. For these kind of videos a capacity of 32 is clearly insufficient as we won't even accommodate a full frame.

I'm not sure I'm entirely comfortable with the dynamic resizing as it introduces some additional state, and unless I'm mistaken we never shrink the buffer.

So that we have a common basis to discuss I've applied a slightly reformatted version of your patch on this branch:

https://github.com/jlaine/aiortc/tree/jitterbuffer-mholt-dv

from aiortc.

@mholt-dv have you had a chance to look at the comments I posted on the code?

from aiortc.

Without feedback on this issue I'll be closing this issue soon.

from aiortc.

Should be fixed by 42f4e0f

from aiortc.