Optimization and consistency for the string example about javascript HOT 5 CLOSED

Good point. Can you send a pull request to use push instead of assigning to unknown indices?

from javascript.

Pull request? Are you serious? I need to fork/clone/edit/save/commit/push/send pull request and go though thousand of UIs. If you find it a good point just change the five bytes in the readme.md via GitHub's edit button. Sorry I'm out of here, I can not contribute any further.

from javascript.

@bobef pull requests are the basic unit of open source contribution. I can't imagine contributing to an open source project without using pull requests.

from javascript.

So reading your guide not for my own sake, because I have no intention of
following it, taking the time to create a ticket although I don't care
about this or any other guide, sharing my experience and elaborating on it
and participating in a discussion, taking more than an hour of my time
doing all of this (in the middle of the night by the way) is not a
contribution? What if I'm a non technical user of open source software
written in C++ and ASM and brainfuck? Should I create pull request to
contribute? Can't I contribute by giving feedback? Can't you imagine this?
:) Here I contribute only with feedback, you don't need to image it, it is
a fact you can see it with your eyes :). I don't want to participate in
writing your guide, I just share my experience (and observations) if you are interested in it.

On Fri, Nov 8, 2013 at 4:47 AM, Spike Brehm [email protected]:

@bobef https://github.com/bobef pull requests are the basic unit of
open source contribution. I can't imagine contributing to an open source
project without using pull requests.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/96#issuecomment-28029156
.

from javascript.

Ah good point. This why we open sourced our style guide for feedback like this.

I think I did it that way because of how the bad example does the string concatenation.

    // bad
    function inbox(messages) {
      items = '<ul>';

      for (i = 0; i < length; i++) {
        items += '<li>' + messages[i].message + '</li>';
      }

      return items + '</ul>';
    }

    // good
    function inbox(messages) {
      items = [];

      for (i = 0; i < length; i++) {
        items[i] = messages[i].message;
      }

      return '<ul><li>' + items.join('</li><li>') + '</li></ul>';
    }

I'll fix this. 🍻

from javascript.