Comments (5)
We already have a library that contains all the protocol specific logic here, and is written in typescript: https://github.com/airgap-it/airgap-coin-lib
Both apps are hybrid apps, which means they are written in javascript, no native code is required for most changes.
Regarding the plugin system: I do like the idea because it would allow users to add features, without our users being affected by it. The main concern regarding new coins and features is that we as a project commit to it to a certain degree, which means our users will expect support going forward. If something breaks, they will expect us to fix it. So we only commit to new coins if we have the backing of the coin itself (except Bitcoin and Ethereum).
While I think this is an interesting idea, the effort required to make this work from us and others (those who are willing to add new coins) is very high. So this feature will most likely not happen any time soon, unless there is high demand from a lot of different projects.
from airgap-vault.
@AndreasGassmann Is there any update towards the plugin system? In my eyes the major issue with AirGap is that it does not support Monero. I understand that it's hard to support it, as it's fundamentally different to Bitcoin, Ethereum and their respective alt coins.
Having a plugin system of some sorts that gives the end user control would allow the community to provide Monero without Monero's developers stepping in. It would unbind you from the responsibility, although it would require you to provide proper desktop apps with plugin support, because I can't imagine the web version supporting plugins without you shipping them.
Or is there already a concept that I'm not aware of?
from airgap-vault.
@martin-braun maybe check this out, it's brand new: https://support.airgap.it/isolated-module
from airgap-vault.
As @mlaeng mentioned, this is a brand new feature and is being rolled out as we speak. Our own protocols are now also running as modules. There is some documentation available, as well as our own modules that can help you understand how it is structured.
One issue I see with the Monero integration is that Monero is not using BIP39 mnemonic. Our modules currently work on a level where the mnemonic is abstracted away from them, so the mnemonic logic is still part of the Vault app itself and cannot be changed by a module. What could currently be done is convert a BIP39 mnemonic, or a derivative of it, into a Monero compatible seed phrase and use that in the module. I think I vaguely remember one of the more popular wallets doing that in their Monero implementation, because their wallet was also multi-chain and was using BIP39.
We would be very happy if you or anyone else from the Monero community would take a stab at creating a Monero module!
Let us know if you need anything to get started.
from airgap-vault.
With the recent implementation of our plugin system, the suggestions raised in this issue have been addressed. I'll be closing it now. If you have any additional questions, please don't hesitate to reopen. Your feedback is appreciated. Thank you!
from airgap-vault.
Related Issues (20)
- Scan this (address) QR code with Metamask does not work HOT 3
- add support for keplr wallet HOT 1
- APK not installing HOT 5
- Support URL Schema Redirect for Companion App HOT 1
- Build reproduction steps
- Request to add support for Avalanche P-chain (for staking). HOT 1
- Use `--output-hashing none` to prevent random names for built main.js HOT 3
- Unable to enable the BIP39 Passphrase on the Android Vault version? HOT 1
- Issue Signing on Optimism HOT 29
- Can you create a Wagmi connector to support the AirGap Vault wallet? HOT 1
- 可以支持中文助记词吗 HOT 1
- Will airgap-vault support stx (stx-i-stack) chain? HOT 1
- publickey check failed. HOT 2
- When the Vault will support OKX Web3 wallet?
- Electrum PSBT QR incompatible code HOT 1
- airgap-vault crashes when generating new seed on a phone with no audio. HOT 1
- Airgap-vault AppImage.
- keystone QR format compatibility HOT 1
- How to add new chain wallet on the vault? HOT 1
- Tag v3.32.1 please HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from airgap-vault.