Giter VIP home page Giter VIP logo

Comments (7)

martint avatar martint commented on August 10, 2024 1

Ok, let me see how we can break the hard dependency. I’m still surprised it’s an issue for Apache, since that’s the license used by the JDK.

from slice.

martint avatar martint commented on August 10, 2024

JOL is licensed under “GPL with classpath exception”, just like all the classes in the JDK. We only use the public APIs in JOL, which are covered by the exception.

from slice.

omalley avatar omalley commented on August 10, 2024

That still leaves it Category X from Apache's point of view, which means that we can't depend on it in Apache projects. Feel free to close this issue if you don't consider it a problem for your users.

from slice.

martint avatar martint commented on August 10, 2024

BTW, the only reason aircompressor depends on Slice is for the XXHash64 implementation that's used to compute checksums in ZSTD. One possibility is to split out the XXHash64 implementation into a separate project and make it work against byte arrays directly.

from slice.

electrum avatar electrum commented on August 10, 2024

It was fairly easy to extract the parts of XxHash64 that are needed by ZSTD (it only uses the static methods and not the stateful hasher): airlift/aircompressor#100

from slice.

omalley avatar omalley commented on August 10, 2024

Any progress on this one? We hacked around it ORC 1.6, but it is absolutely a hack.

from slice.

electrum avatar electrum commented on August 10, 2024

@omalley aircompressor no longer depends on Slice (and thus JOL) as of release 0.16. (I commented about this on ORC-363 but you probably didn't see it.)

I'm going close this issue since we have no current plans to remove the dependency on JOL in Slice, and I think the actual concern here was aircompressor. If that's not the case, please reopen.

from slice.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.