Move to Semantic Versioning about airsonic HOT 6 CLOSED

Comment by csobsidian
Thursday May 05, 2016 at 13:48 GMT

I don't currently have a system setup with the proper tool chain but here's what I've found:

The Version Service has an embedded URL for pulling the most recent version info.
private static final String VERSION_URL = "http://subsonic.org/backend/version.view";

This page currently returns the following information:

SUBSONIC_VERSION_BEGIN6.0SUBSONIC_VERSION_END
SUBSONIC_FULL_VERSION_BEGIN6.0SUBSONIC_FULL_VERSION_END
SUBSONIC_BETA_VERSION_BEGIN6.0.beta2SUBSONIC_BETA_VERSION_END

This information is then compared to a version string stored in a text file at ./WEB-INF/classes/version.txt. That local text file is created from the POM.xml at build time and contains the current project version:

<parent>
  <groupId>net.sourceforge.subsonic</groupId>
  <artifactId>subsonic</artifactId>
  <version>6.0.beta1</version>
</parent>

Callers to the version service such as the Right Controller use this information to setup the proper view.

if (userSettings.isFinalVersionNotificationEnabled() && versionService.isNewFinalVersionAvailable() {
  map.put("newVersionAvailable", true);
  map.put("latestVersion", versionService.getLatestFinalVersion());
} else if (userSettings.isBetaVersionNotificationEnabled() && versionService.isNewBetaVersionAvailable()) {
  map.put("newVersionAvailable", true);
  map.put("latestVersion", versionService.getLatestBetaVersion());
}

For the near term the implications appear to be as simple as redirecting the version service to a new URL maintained by Libresonic. Long term this is wrapped into the re-branding and move away from the subsonic namespace.

from airsonic.

Comment by EugeneKay
Sunday May 08, 2016 at 18:32 GMT

ba28695 changes the VersionService URL to use libresonic.org. I have placed a plaintext file at the appropriate location and listed 5.3 as the current version.

This change does not appear to work on my test instance with the log error "Failed to resolve latest Subsonic version". I suspect Let's Encrypt is not in the Java SSL keystore? Input/testing welcomed.

from airsonic.

Comment by csobsidian
Monday May 09, 2016 at 20:20 GMT

[2016-05-09 13:06:18,052] WARN VersionService - Failed to resolve latest Subsonic version.
javax.net.ssl.SSLException: hostname in certificate didn't match: <libresonic.org> != <*.kashpureff.org> OR <*.kashpureff.org> OR <kashpureff.org> OR <www.kashpureff.org>
    at org.apache.http.conn.ssl.AbstractVerifier.verify(AbstractVerifier.java:227)
    at org.apache.http.conn.ssl.BrowserCompatHostnameVerifier.verify(BrowserCompatHostnameVerifier.java:54)
    at org.apache.http.conn.ssl.AbstractVerifier.verify(AbstractVerifier.java:147)
...

from airsonic.

Comment by EugeneKay
Monday May 09, 2016 at 20:24 GMT

That means that this is a ServerNameIndication issue in Libresonic or the Java stdlib..... Ugh. A quick search yields https://issues.apache.org/jira/browse/HTTPCLIENT-1119 among others.

from airsonic.

Comment by EugeneKay
Tuesday May 10, 2016 at 14:56 GMT

@zifnab06 volunteered to look at this.

from airsonic.

Comment by EugeneKay
Saturday May 14, 2016 at 20:35 GMT

I have bumped the version numbers(dc2d450). I have decided to revert to using a HTTP URL for now(b90eb07) and opened #74 for a future release.

from airsonic.