Some sort of unique promise ID to track with? about angular-promise-tracker HOT 7 CLOSED

I think this is a feature which is definitely needed. It's also not hard to implement, but currently, listeners are just get pushed to a callbacks array and then get fired at a certain point. Now.. when taking a look at this construct... wouldn't it be cooler to use $rootScope.$broadcast() for the whole event handling? @ajoslin, what do you say?

from angular-promise-tracker.

We could use $rootScope.$broadcast.. But it seems bad to make the whole scope hierarchy be traversed for events every time any promise tracked does anything (which could potentially be many times per minute). Also the syntax is bad (look below).

...and for the callbacks, how about this (if we went with the current syntax):

myTracker.on('start', function(startArgument, promiseId) {
}).on('done', function(doneArg, promiseId) {
});

If we went with scope events, it would be:

$scope.$on('promiseTracker.start', function($event, promiseTracker, promiseId, startArg) {
});

That's too ugly IMO.

I'll be using AngularJS's nextUid function so I will never run out of ids.

from angular-promise-tracker.

Yep, perfect! That's exactly what I had in mind!

Didn't even know about their nextUid function, so thanks for that as well!

from angular-promise-tracker.

Done in 94a62dc :-)

Check the commit notes for an example.

from angular-promise-tracker.

@ajoslin Great job! Just for the records: You aren't able to use angular's nextUid function (without defining it in your provider)?

from angular-promise-tracker.

Angular's isn't exposed unfortunately - it's private.

from angular-promise-tracker.

Hmpf. Okay.

from angular-promise-tracker.