Giter VIP home page Giter VIP logo

Comments (5)

ajthinking avatar ajthinking commented on June 12, 2024

Hi @LukasFreyCZ, do you have any preference on this? How would you like it to behave?

from archetype.

lukas-frey avatar lukas-frey commented on June 12, 2024

Hi, thank you for looking at it!

I imagine the set function would overwrite all other traits (since I think this is how all the other endpoints work, too).
Each call to useTrait() chained with an add() call would then append a new line. If you pass an array, it would add multiple traits in one line, if you pass a single class name, it would create a separate trait.

To add the traits from your example, you would run the following:

PHPFile::load(X::class)->add()
->useTrait([TraitA::class, TraitB::class, TraitC::class])
// OR just ->useTrait(TraitA::class, TraitB::class, TraitC::class) using the splat operator.
->useTrait(TraitD::class)
->useTrait(TraitE::class);

I personally don't mind too much how the resulting file will look visually in the end, whether it will be one big line with all traits or multiple lines.

If you need some assistance with the code or testing, I'm available in the evening hours (+20:00 CEST) :)

from archetype.

ajthinking avatar ajthinking commented on June 12, 2024

Greatly appreciated @LukasFreyCZ , please see #77 for a first iteration of this. I'll put you as reviewer.
EDIT: could not add you as a reviewer for some reason, but anyways :)

from archetype.

ajthinking avatar ajthinking commented on June 12, 2024

Merged and released in v1.1.5 🎉

from archetype.

lukas-frey avatar lukas-frey commented on June 12, 2024

Merged and released in v1.1.5 🎉

Thank you so much for adding it. Sorry that I didn't respond sooner, I was out of office.

from archetype.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.