Default export broken for typescript moduleResolution node16 about ajv HOT 10 OPEN

Interesting tool @apottere, it does indeed look all green.

This is compared with what we currently have

I'll just check it out a bit more, but looking good 👍

from ajv.

any updates on this?

from ajv.

Looks good in https://arethetypeswrong.github.io/?p=%40benasher44%2Fajv%408.12.1 and seems to resolve the issue in my reproduction 👍

from ajv.

Hi there, thanks for raising this.

Do you think this can be replicated in https://runkit.com/ ? Or would it need to be in a project.

I am wondering though, given Node 16 had it's EOL brought forward by 7 months due to potential vulnerabilities, should we actually by dropping support for node 16?

from ajv.

I haven't used runkit before but I'll take a look.

The node16 module resolution name is confusing. It isn't the module resolution for node 16, it's the module resolution compatible with the changes introduced in node 16. Per the docs:

'node16' or 'nodenext' for modern versions of Node.js. Node.js v12 and later supports both ECMAScript imports and CommonJS require, which resolve using different algorithms. These moduleResolution values, when combined with the corresponding module values, picks the right algorithm for each resolution based on whether Node.js will see an import or require in the output JavaScript code.

As of now, node16 is the most up-to-date value for moduleResolution (not including bundler of course).

from ajv.

It looks like there's no way to fiddle with builds in runkit, so I create a minimal reproduction here: https://github.com/apottere/ajv-typescript-node16

from ajv.

I see, I will take a look, thanks.

from ajv.

This should be fixed by #2365. Can you try @benasher44/ajv? I published that PR there

from ajv.

When can we expect the fix to be in? Thanks

from ajv.