Comments (4)
Hey, I'd like to take this issue on. I'll be opening a PR for with the fix shortly. Thanks for the excellent detail in the original issue description.
from css-spinners-react.
No problem @danditomaso, thanks for your help!
from css-spinners-react.
Hey @ajwann and @danditomaso
I realize this PR is closed but wanted to point out that you could simplify these components even further. You could turn this
const Atebits = props => {
return(
<div className="atebits-loader" {...props} />
)
}
Into this
const Atebits = props => <div className="atebits-loader" {...props} />
This is entirely subjective but I think it's much easier to read with the implicit return.
from css-spinners-react.
Oh, one more thing... You can consolidate the component export to look something like this
export const Atebits = props => <div className="atebits-loader" {...props} />
from css-spinners-react.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from css-spinners-react.