Substitution Variables section in WebRequest is out of date about last-watch-ai HOT 6 CLOSED

Also, it would be great if we could replace to the thumbnail URL directly, instead of having to get the event ID, call, the API, then get the thumbnail image... same might apply to the image itself, as it seems the /api/events/{ID}/img is fairly slow compared to just pulling /storage/events/{GUID}.jpeg (understandable, as it's calling the DB and what not).

from last-watch-ai.

On second thought... another solution might be that instead of having randomly generated GUID used within /storage/events/GUID.jpeg, maybe using some simple hashing like MD5 or so based on the original file name (i.e. %image_file_name%), that way no need to call the API to get the storage location, as long as you already have the original filename

from last-watch-ai.

For anyone interested, for the comment above (about been able to get the direct image link, instead of a link that tries to "download" the image), I made a minor change in my local PayloadHelper.php and it's working great. I just added the following line before the "return $replaced;":

$replaced = str_replace('%image_path%', $event->imageFile->getPath(), $replaced);

This works great for my use case which is BI sending alert images to Last-Watch-AI, which then triggers a web-hook that triggers a push notification to a PWA. When the user clicks on the PWA's notification is a direct link to the Last-Watch_AI image that triggered the event. This is way faster than the /api/events/{ID}/img call

from last-watch-ai.

I actually have some changes in the dev branch to clean up the substitution variables and standardize them across the different automation types. The substitution code was pretty rushed so I'm not surprised that you found some gaps there. I'll see about adding some variables for direct jpg links for the event and the thumbnail rather than the resource url.

from last-watch-ai.

See acb73d2

Changed image_url to use the storage link instead of the resource link as you suggested. Added a new variable for the resource link which is still useful for embedding download links which retain the original file name.

I had already fixed the issues you described but I've been busy the last few weeks and haven't released it. Web request substitutions are fixed and tested, but I started adding substitutions for MQTT automations and I haven't written those tests yet. Once I write the tests for MQTT I'll do a new release. Until then you can pull dev if you want. I actually use the dev branch for my home automation and everything has been working fine.

Thanks for your support!

from last-watch-ai.

This is great, will pull the dev branch. Thanks!

from last-watch-ai.