Giter VIP home page Giter VIP logo

Comments (6)

akonwi avatar akonwi commented on August 18, 2024

That looks like the output view. It's a view that's serialized and restored across window sessions. If you close it and don't open it again, it shouldn't be restored automatically. Is that the case?

from git-plus.

Frk7 avatar Frk7 commented on August 18, 2024

That looks like the output view. It's a view that's serialized and restored across window sessions. If you close it and don't open it again, it shouldn't be restored automatically. Is that the case?

Yes. it's the output view, it's restored when you open a new window or when you close and reopen Atom.
It wuold be nice to have a setting to create it or not on startup. I can always click on git+ on the status bar or set a keyboard shortcut to show the output when I need it.

from git-plus.

akonwi avatar akonwi commented on August 18, 2024

Since this is really an artifact of how atom serializes and deserializes workspaces, I'd suggest the manual band-aid for now until the setting is added, which is to keep that bottom dock closed and toggle it when you want. The window should only be restored to the way it was before it was torn down. So if the dock was open, it will be open at the next startup of that same set of project folders.

Pull requests are welcome by the way 😄

from git-plus.

Frk7 avatar Frk7 commented on August 18, 2024

I've not been very clear. I meant the split pane's creation (including the toggle arrow) not the closed/open state 😅
I don't even want to see the toggle arrow to open the split pane after Atom startup beacuse for me it's annoying to have it there, so I have to remove the entire pane by clicking on the cross button of the only existing 'Git+' tab.
I updated the issue title and my comments.

from git-plus.

akonwi avatar akonwi commented on August 18, 2024

Oh now I see. So atom calls those toggle-able panes, docks, and when I read split-pane, I thought you were saying new tabs are being created in the center of the workspace.

Here's a gif demonstrating the dock serialization behavior I see. If yours is doing something else, then I'd like to know why.

docks

If your dock behavior is the same, then my suggestion to just keep the dock closed and toggle it when you need to should solve your problem for now.

from git-plus.

Frk7 avatar Frk7 commented on August 18, 2024

The problem is that i don't want the dock to be created if destroyed before (i can click on git+ on the status bar if I want to create it) because the toggle arrow annoys me (reason in my 1st post).

If I close the last tab in the dock and the dock is destroyed, I want it to stay destroyed (so no toggle arrow has to be present in the window) after reloading the window.

I think in code the dock's view is OutputViewContainer. So I would propose to add a setting (like notAutocreateDockAtStartup) or to check the last state == destroyed (or both), e.g. at creation time:

if (this.outputView === null && GitPlusSettings.notAutocreateDockAtStartup
    && lastOutputViewState === 'destroyed') {
  // outputView remains null
} else {
  this.outputView = new OutputViewContainer();
}

from git-plus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.