Using just the dist-folder isn't working (BuildingNavigator is not defined) about building-navigator HOT 11 CLOSED

Should solved with latest commit 17e6db3 (it was an old main.min.js)

from building-navigator.

Do you update dist/main.min.js on file changes or do i have to do that manually?

from building-navigator.

from building-navigator.

Many steps neccessary? Can we move that into a Makefile or something to reduce the time load?

from building-navigator.

from building-navigator.

But I don't think it's a good idea the recreate the dist with each new commit

Why not? The dist folder should be valid and contain the latest changes. If we want to carry out packages, which update only after days/weeks/months ... we could use Github's release section. But i wanted to use the dist from the beginning, to be able to try out the app without any further work.

Could you sketch here how it should work to update dist-folder manually, by calling like make update-dist. On each Git commit sounds hard to implement.

from building-navigator.

177bf27 implements command npm build-dist. It has to executed in the running Docker container.

from building-navigator.

Thanks! Will look into it.

from building-navigator.

Please use this for round 3.

package.json:

"devDependencies": {
        ...
        "write-file-webpack-plugin": "*"
    }

webpack.config.json:

...
var WriteFilePlugin = require('write-file-webpack-plugin');

module.exports = {
    ...
    output: {
        ...
    },
    plugins: [
        new WriteFilePlugin() // plugin to write compiled JS into dist folder
    ],
    ...
}

from building-navigator.

As I pointed out the disadvantages of using WriteFilePlugin (esp. js min size) we may close this issue?

To build dist on each commit/push we can create a pre-push hook as a reminder or programmatically create dist and append to commit.

from building-navigator.

As we decided we use two configurations, dev and prod, for future releases.

from building-navigator.