use_thin_strokes has no effect on macOS 12 about crossfont HOT 8 CLOSED

Can you configure this default actually? Patches are always welcome, especially for macOS, given that it's not what core contributors use.

I'll be the one reviewing patch anyway, so go ahead.

from crossfont.

cg_context.set_font_smoothing_style(16);
cg_context.set_allows_font_smoothing(false);
cg_context.set_should_smooth_fonts(false);

It seems to me like these three lines would be in conflict with each other? When you disable font smoothing, surely setting the font smoothing style doesn't make any sense?

from crossfont.

cg_context.set_font_smoothing_style(16);
cg_context.set_allows_font_smoothing(false);
cg_context.set_should_smooth_fonts(false);

It seems to me like these three lines would be in conflict with each other? When you disable font smoothing, surely setting the font smoothing style doesn't make any sense?

then cg_context.set_font_smoothing_style(16); should be moved to

else {
}

anyway, it works with the mod in my first post. all the non english words got thin strokes as well. (Prior to the mod, using Light font style could be a trick, but CJK words still show thick style )

from crossfont.

then cg_context.set_font_smoothing_style(16); should be moved to

You want to move logic that previously only applied to one conditional block to the opposite block? That doesn't make much sense, does it?

from crossfont.

then cg_context.set_font_smoothing_style(16); should be moved to

You want to move logic that previously only applied to one conditional block to the opposite block? That doesn't make much sense, does it?

well, i am not the one that made the patch, but i tested it, it works on macOS 12, all characters are thin stroke, with use_thin_strokes: true. i don't quite know how the code works actually :)

from crossfont.

i don't quite know how the code works actually

Well, if nobody knows how the code works, then it certainly will not be merged.

If I'm going to send any PR to change the thin strokes behavior on macOS, it will be to remove it completely. I'm personally not interested in this feature and think it's not very beneficial to have anymore.

So if someone else actually cares about thin strokes, they should put in the effort to figure these things out and ensure they work on all macOS systems. Just sending in some patch that might work some of the time won't cut it.

from crossfont.

@chrisduerr I've been experimenting with this a bit and have a patch of crossfont and alacritty that decides what to do based on the AppleFontSmoothing user default, which is what the system uses now to decide this behavior, rather than having this as a preference in alacritty/crossfont. Is this something you would be interested in? If so I can polish it up and push it for review, but don't want to waste your time if that's not an approach you'd prefer.

from crossfont.

@kchibisov Sure, I will open a PR and we can discuss further there.

from crossfont.