Add prop types for Popup components about deadviz HOT 9 CLOSED

Hello! Can I solve this issue?

from deadviz.

Sure @SofiaSimas . I'll assign this to you, please make sure the prop types are complete for all possible props

from deadviz.

@aladhims I found only one missed proptype in components submission.
Is there any others that you know?

from deadviz.

@SofiaSimas I have requested changes on your PR, please take a look at other components, for submission looks good 👍

from deadviz.

@aladhims This issue has not been resolved. Can you assign to me? Thanks

from deadviz.

Hm sure, since we haven't heard any update from previous assignee, i will re-assign this to you @phanlyhuynh

from deadviz.

Just to remind you, please make sure you will also add prop types for all components under submission @phanlyhuynh

from deadviz.

@aladhims sure. I fixed it, #15. Thanks

from deadviz.

solved on #15

from deadviz.