Giter VIP home page Giter VIP logo

Comments (10)

alanmcgovern avatar alanmcgovern commented on June 7, 2024 1

I wonder if this will shed some light on the problem: #620

If you don't have logging enabled/redirected, you can redirect logging to a file by replacing Console.Out with a regular filestream/something and registering a function here. Note: You should do this right at the start of your app so everything initialises correctly.

https://github.com/alanmcgovern/monotorrent/blob/master/src/Samples/SampleClient/StandardDownloader.cs#L35

I have moderate hope this will identify the issue you're hitting :)

from monotorrent.

ManlyMarco avatar ManlyMarco commented on June 7, 2024 1

Confirming the issue is fixed.

from monotorrent.

alanmcgovern avatar alanmcgovern commented on June 7, 2024

Hrm... That specific exception is suspect. It implies the underlying data is incomplete, i.e. a partial Http response was received.

Could you add a line of logging around this area of the code, probably prior to the if/else, to print out the content length of the response:

monotorrent/src/MonoTorrent.Trackers/MonoTorrent.Connections.Tracker/HTTPTrackerConnection.cs

Line 215 in a8c7a6c

while ((bytesRead = await reader.ReadAsync (buffer, 0, (int) Math.Min (contentLength - totalRead, buffer.Length)).ConfigureAwait (false)) > 0) {

Also, if you dump the Memory stream to disk using System.Text.Encoding.ASCII to encode the bytes, it should be possible to eyeball the result and see what the content is. It might make it clearer whether the response is incomplete, or completely invalid.

from monotorrent.

ManlyMarco avatar ManlyMarco commented on June 7, 2024

Here's a dump of a failed response (copy of dataStream MemoryStream)

There is a lot of these being thrown:
image
It's all with family == AddressFamily.InterNetworkV6. I only enabled IPv4 on both the server and client with:
ListenEndPoints = new Dictionary<string, IPEndPoint> { { "ipv4", new IPEndPoint(IPAddress.Any, port) } },

Tracker has this as a sole listener, so I guess it's trying to only use IPv6?

var trackerEndpointHttp = $"*:{trackerPortHttp}";
var listenerHttp = TrackerListenerFactory.CreateHttp($"http://{trackerEndpointHttp}/announce/");

Edit: When the BEncodedValue.Decode fails the reply seems to be empty, writing the response to file results in 0 bytes.
response
empty headers

Not sure how to debug it from there. The response status code is "OK".
Edit2: Here's a wireshark capture, it looks like the issue might be on the server side?

from monotorrent.

alanmcgovern avatar alanmcgovern commented on June 7, 2024

It's all with family == AddressFamily.InterNetworkV6. I only enabled IPv4 on both the server and client with:

There's some cleanup which could be done here to reduce the frequency at which exceptions are thrown here, but it shouldn't make a difference to the actual behaviour or success of the library. The ipv6 tracker extensions state that the client should make both an ipv4 and ipv6 connection when announcing/scraping. If the tracker you're hosting only listens on ipv4, then the ipv6 announce from the client will fail. At this point the overall announce to the tracker will be considered a success as at least 1 announce variant succeeded. This way you can get ipv4 peers, ipv6 peers, or both ipv4+ipv6 peers.

Edit: When the BEncodedValue.Decode fails the reply seems to be empty, writing the response to file results in 0 bytes.

That's surprising! I'll review the TrackerServer code and try to see how this could happen. Actualy i just noticed the wireshark cap so i'll check that out first! Thanks!

from monotorrent.

alanmcgovern avatar alanmcgovern commented on June 7, 2024

@ManlyMarco Is this capture from a time when the response appeared empty on the client side? If so, the bug has to be on the client side as the capture does show the response has the expected data, and contentlength.

Huh.

data_from_tracker

I'll assume this capture is from a time when the bug occurred and double check how HttpClient is reading the data.

Edit: Which .net framework version are you running under? I recently added a dependency on a 3rd party nuget as it was the only viable way of implementing the IPv6 tracker extensions, and I'm a little worried that the bug you're seeing is in that nuget.

If you're using .NET 4.7.2/4.8.x, could you try under .NET 6.0 and see if the behaviour is the same? If you're already using .NET 6.0 then it's definitely not that nuget.

from monotorrent.

ManlyMarco avatar ManlyMarco commented on June 7, 2024

I'm using .NET Framework 4.7.2. Running the code in .NET 6.0 does seem to make a difference but it still throws an exception in the same spot, this time System.NotSupportedException: 'This protocol version is not supported.'. Either way it seems to work the same in the end. My ISP doesn't support IPv6 and neither does my server's ISP (also I disabled TCP/IPv6 in my network adapter properties), so these connections are expected to fail, but it's weird that it's even trying them when I specifically did not add ipv6 to ListenEndPoints. The exception is ultimately caught so it's fine as long as the actual ipv4 connection succeedes.

I'm trying to reproduce the issue with the more detailed logging enabled, but of course it doesn't happen when I'm trying to get it to happen. It seems to have fixed itself somehow, at least for now. I'll have to test it in the same environment as before tomorrorow. I'll keep the logging enabled and if the issue reappears I'll let you know.

For now I sidestepped the issue of unreliable tracker connection by manually adding the seed (I know it's IP since it's the same as the tracker given in the torrent file and the port never changes) and enabling peer exchange - this seems to always work.

from monotorrent.

ManlyMarco avatar ManlyMarco commented on June 7, 2024

Here's what I've got, it seems to randomly crash parsing the incoming tracker requests, but not all of them.
All of the torrents are created in the exact same way with only contained files and names being different. The same tracker is used for all of them. HTTP tracker is on port 15846 while the seed is on port 15847. Client uses port 15847 but is behind a VPN.

Client log (x is server IP):

[16:09:39] INFO: HttpTrackerConnection:Unknown scrape tag received: Key name  Value test torrent - c
[16:09:39] INFO: HttpTrackerConnection:Unknown scrape tag received: Key name  Value test torrent - d
[16:09:39] INFO: HttpTrackerConnection:Unknown scrape tag received: Key name  Value test torrent - e
[16:09:39] INFO: HttpTrackerConnection:Unknown scrape tag received: Key name  Value test torrent - f
[16:09:39] INFO: HttpTrackerConnection:Unknown scrape tag received: Key name  Value test torrent - i
[16:09:39] INFO: HttpTrackerConnection:Unknown scrape tag received: Key name  Value test torrent - j
[16:09:39] [test torrent - i] ScrapeComplete Successful=True Tracker=http://xx.xx.xxx.xxx:15846/announce
[16:09:39] [test torrent - j] ScrapeComplete Successful=True Tracker=http://xx.xx.xxx.xxx:15846/announce
[16:09:39] [test torrent - d] ScrapeComplete Successful=True Tracker=http://xx.xx.xxx.xxx:15846/announce
[16:09:39] [test torrent - c] ScrapeComplete Successful=True Tracker=http://xx.xx.xxx.xxx:15846/announce
[16:09:39] [test torrent - f] ScrapeComplete Successful=True Tracker=http://xx.xx.xxx.xxx:15846/announce
[16:09:39] [test torrent - e] ScrapeComplete Successful=True Tracker=http://xx.xx.xxx.xxx:15846/announce
[16:09:39] INFO: HttpTrackerConnection:Tracker http://xx.xx.xxx.xxx:15846/announce sent 2 peers for InfoHash MonoTorrent.InfoHash
[16:09:39] INFO: HttpTrackerConnection:Tracker http://xx.xx.xxx.xxx:15846/announce sent 2 peers for InfoHash MonoTorrent.InfoHash
[16:09:39] INFO: HttpTrackerConnection:Tracker http://xx.xx.xxx.xxx:15846/announce sent 2 peers for InfoHash MonoTorrent.InfoHash
[16:09:39] INFO: HttpTrackerConnection:Tracker http://xx.xx.xxx.xxx:15846/announce sent 2 peers for InfoHash MonoTorrent.InfoHash
[16:09:39] INFO: HttpTrackerConnection:Tracker http://xx.xx.xxx.xxx:15846/announce sent 2 peers for InfoHash MonoTorrent.InfoHash
[16:09:39] INFO: HttpTrackerConnection:Tracker http://xx.xx.xxx.xxx:15846/announce sent 2 peers for InfoHash MonoTorrent.InfoHash
[16:09:39] INFO: HttpTrackerConnection:Tracker http://xx.xx.xxx.xxx:15846/announce sent 2 peers for InfoHash MonoTorrent.InfoHash
[16:09:39] INFO: TrackerTier:Announced to http://xx.xx.xxx.xxx:15846/announce
[16:09:39] INFO: TrackerTier:Announced to http://xx.xx.xxx.xxx:15846/announce
[16:09:39] INFO: TrackerTier:Announced to http://xx.xx.xxx.xxx:15846/announce
[16:09:39] INFO: TrackerTier:Announced to http://xx.xx.xxx.xxx:15846/announce
[16:09:39] INFO: TrackerTier:Announced to http://xx.xx.xxx.xxx:15846/announce
[16:09:39] INFO: TrackerTier:Announced to http://xx.xx.xxx.xxx:15846/announce
[16:09:39] INFO: TrackerTier:Announced to http://xx.xx.xxx.xxx:15846/announce
[16:09:39] [test torrent - d] AnnounceComplete Successful=True Tracker=http://xx.xx.xxx.xxx:15846/announce PeersCount=1
[16:09:39] [test torrent - i] AnnounceComplete Successful=True Tracker=http://xx.xx.xxx.xxx:15846/announce PeersCount=1
[16:09:39] [test torrent - k] AnnounceComplete Successful=True Tracker=http://xx.xx.xxx.xxx:15846/announce PeersCount=1
[16:09:39] [test torrent - c] AnnounceComplete Successful=True Tracker=http://xx.xx.xxx.xxx:15846/announce PeersCount=1
[16:09:39] [test torrent - j] AnnounceComplete Successful=True Tracker=http://xx.xx.xxx.xxx:15846/announce PeersCount=1
[16:09:39] [test torrent - m] AnnounceComplete Successful=True Tracker=http://xx.xx.xxx.xxx:15846/announce PeersCount=1
[16:09:39] [test torrent - b] AnnounceComplete Successful=True Tracker=http://xx.xx.xxx.xxx:15846/announce PeersCount=1
[16:09:39] [test torrent - b] PeersFound ExistingPeers=0 NewPeers=1
[16:09:39] [test torrent - d] PeersFound ExistingPeers=0 NewPeers=1
[16:09:39] [test torrent - c] PeersFound ExistingPeers=0 NewPeers=1
[16:09:39] [test torrent - m] PeersFound ExistingPeers=0 NewPeers=1
[16:09:39] [test torrent - i] PeersFound ExistingPeers=0 NewPeers=1
[16:09:39] [test torrent - k] PeersFound ExistingPeers=0 NewPeers=1
[16:09:39] [test torrent - j] PeersFound ExistingPeers=0 NewPeers=1
[16:09:39] INFO: ConnectionManager:Trying to connect to ipv4://xx.xx.xxx.xxx:15847/
[16:09:39] INFO: ConnectionManager:Trying to connect to ipv4://xx.xx.xxx.xxx:15847/
[16:09:39] INFO: ConnectionManager:Trying to connect to ipv4://xx.xx.xxx.xxx:15847/
[16:09:39] INFO: ConnectionManager:ipv4://xx.xx.xxx.xxx:15847/: Connection opened
[16:09:39] INFO: ConnectionManager:ipv4://xx.xx.xxx.xxx:15847/: [outgoing] Sending handshake message with peer id '-MO3000-023404528852'
[16:09:39] INFO: ConnectionManager:ipv4://xx.xx.xxx.xxx:15847/: Connection opened
[16:09:39] INFO: ConnectionManager:ipv4://xx.xx.xxx.xxx:15847/: [outgoing] Sending handshake message with peer id '-MO3000-023404528852'
[16:09:39] INFO: ConnectionManager:Trying to connect to ipv4://xx.xx.xxx.xxx:15847/
[16:09:39] INFO: HttpTrackerConnection:Unknown scrape tag received: Key name  Value test torrent - a
[16:09:39] INFO: HttpTrackerConnection:Unknown scrape tag received: Key name  Value test torrent - b
[16:09:39] INFO: HttpTrackerConnection:Tracker http://xx.xx.xxx.xxx:15846/announce sent 2 peers for InfoHash MonoTorrent.InfoHash
[16:09:39] INFO: TrackerTier:Announced to http://xx.xx.xxx.xxx:15846/announce
[16:09:39] INFO: HttpTrackerConnection:Unknown scrape tag received: Key name  Value test torrent - m
[16:09:39] INFO: TrackerTier:Announced to http://xx.xx.xxx.xxx:15846/announce
[16:09:39] INFO: ConnectionManager:ipv4://xx.xx.xxx.xxx:15847/: Connection opened
[16:09:39] INFO: ConnectionManager:ipv4://xx.xx.xxx.xxx:15847/: [outgoing] Sending handshake message with peer id '-MO3000-023404528852'
[16:09:40] INFO: ConnectionManager:ipv4://xx.xx.xxx.xxx:15847/: Connection opened
[16:09:40] INFO: ConnectionManager:ipv4://xx.xx.xxx.xxx:15847/: [outgoing] Sending handshake message with peer id '-MO3000-023404528852'
[16:09:40] INFO: HttpTrackerConnection:Unknown scrape tag received: Key name  Value test torrent - k
[16:09:40] INFO: HttpTrackerConnection:Tracker http://xx.xx.xxx.xxx:15846/announce sent 2 peers for InfoHash MonoTorrent.InfoHash
[16:09:40] INFO: TrackerTier:Announced to http://xx.xx.xxx.xxx:15846/announce
[16:09:40] INFO: ConnectionManager:ipv4://xx.xx.xxx.xxx:15847/: [outgoing] Received handshake message with peer id '-MO3000-182563814012'
[16:09:40] INFO: ConnectionManager:ipv4://xx.xx.xxx.xxx:15847/: [outgoing] Received handshake message with peer id '-MO3000-182563814012'
[16:09:40] INFO: ConnectionManager:ipv4://xx.xx.xxx.xxx:15847/: [outgoing] Received handshake message with peer id '-MO3000-182563814012'
[16:09:40] INFO: ConnectionManager:ipv4://xx.xx.xxx.xxx:15847/: [outgoing] Received handshake message with peer id '-MO3000-182563814012'
[16:09:41] INFO: HttpTrackerConnection:Unknown scrape tag received: Key name  Value test torrent - k
[16:09:41] INFO: TrackerTier:Announced to http://xx.xx.xxx.xxx:15846/announce

Server log (y is client IP):

ERROR:HttpTrackerListener:Error processing announce from peer
System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'port')
   at System.Net.IPEndPoint..ctor(IPAddress address, Int32 port)
   at MonoTorrent.TrackerServer.AnnounceRequest..ctor(NameValueCollection collection, IPAddress address)
   at MonoTorrent.Connections.TrackerServer.TrackerListener.Handle(NameValueCollection collection, IPAddress remoteAddress, Boolean isScrape)
   at MonoTorrent.Connections.TrackerServer.TrackerListener.Handle(String queryString, IPAddress remoteAddress, Boolean isScrape)
   at MonoTorrent.Connections.TrackerServer.HttpTrackerListener.ProcessContextAsync(HttpListenerContext context, CancellationToken token)
INFO: ListenManager:ipv4://yyy.yyy.yy.yyy:58411/: ConnectionReceived
INFO: ListenManager:ipv4://yyy.yyy.yy.yyy:50603/: ConnectionReceived
INFO: ListenManager:ipv4://yyy.yyy.yy.yyy:52429/: ConnectionReceived
INFO: ListenManager:ipv4://yyy.yyy.yy.yyy:41189/: ConnectionReceived
INFO: ListenManager:ipv4://yyy.yyy.yy.yyy:50603/: [incoming] Received handshake with peer_id '-MO3000-023404528852'
INFO: ListenManager:ipv4://yyy.yyy.yy.yyy:50603/: Handshake successful handled
INFO: ConnectionManager:ipv4://yyy.yyy.yy.yyy:50603/: Incoming connection fully accepted
INFO: ConnectionManager:Incoming connection fully accepted
INFO: ListenManager:ipv4://yyy.yyy.yy.yyy:58411/: [incoming] Received handshake with peer_id '-MO3000-023404528852'
INFO: ListenManager:ipv4://yyy.yyy.yy.yyy:58411/: Handshake successful handled
INFO: ConnectionManager:ipv4://yyy.yyy.yy.yyy:58411/: Incoming connection fully accepted
INFO: ListenManager:ipv4://yyy.yyy.yy.yyy:52429/: [incoming] Received handshake with peer_id '-MO3000-023404528852'
INFO: ListenManager:ipv4://yyy.yyy.yy.yyy:52429/: Handshake successful handled
INFO: ConnectionManager:ipv4://yyy.yyy.yy.yyy:52429/: Incoming connection fully accepted
INFO: ConnectionManager:Incoming connection fully accepted
INFO: ConnectionManager:Incoming connection fully accepted
INFO: ListenManager:ipv4://yyy.yyy.yy.yyy:41189/: [incoming] Received handshake with peer_id '-MO3000-023404528852'
INFO: ListenManager:ipv4://yyy.yyy.yy.yyy:41189/: Handshake successful handled
INFO: ConnectionManager:ipv4://yyy.yyy.yy.yyy:41189/: Incoming connection fully accepted
INFO: ConnectionManager:Incoming connection fully accepted
ERROR:HttpTrackerListener:Error processing announce from peer
System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'port')
   at System.Net.IPEndPoint..ctor(IPAddress address, Int32 port)
   at MonoTorrent.TrackerServer.AnnounceRequest..ctor(NameValueCollection collection, IPAddress address)
   at MonoTorrent.Connections.TrackerServer.TrackerListener.Handle(NameValueCollection collection, IPAddress remoteAddress, Boolean isScrape)
   at MonoTorrent.Connections.TrackerServer.TrackerListener.Handle(String queryString, IPAddress remoteAddress, Boolean isScrape)
   at MonoTorrent.Connections.TrackerServer.HttpTrackerListener.ProcessContextAsync(HttpListenerContext context, CancellationToken token)

from monotorrent.

alanmcgovern avatar alanmcgovern commented on June 7, 2024

Ah interesting! It looks like perhaps a default port is propagating to the tracker, instead of being replaced with the actual listen port the client is using.

There are two fixes:

  1. The tracker should be made robust against this. If an invalid port is sent, it should replace it with '0' and send a warning back to the client after fulfilling the announce. This is what the warning part of the announce response is for!

  2. Figure out why the client is sending a port of -1. I assume this is what's happening based on the exception and the fact -1 is the default here:

            Func<string, (string?, int)> reportedAddressFunc = type => {
                string? ip = null;
                int port = engine.GetOverrideOrActualListenPort (type).GetValueOrDefault (-1);
                if (engine.Settings.ReportedListenEndPoints.TryGetValue (type, out var reportedAddress))
                    ip = reportedAddress.Address.ToString ();
                return (ip, port);
            };

The implementation of that is:

monotorrent/src/MonoTorrent.Client/MonoTorrent.Client/ClientEngine.cs

Lines 1016 to 1025 in 0c919b2

if (Settings.ReportedListenEndPoints.TryGetValue(scheme, out var endPoint) && endPoint.Port != 0)
return endPoint.Port;
foreach (var listener in PeerListeners) {
if (scheme == "ipv4" && listener.LocalEndPoint != null && listener.LocalEndPoint.AddressFamily == AddressFamily.InterNetwork)
return listener.LocalEndPoint.Port;
if (scheme == "ipv6" && listener.LocalEndPoint != null && listener.LocalEndPoint.AddressFamily == AddressFamily.InterNetworkV6)
return listener.LocalEndPoint.Port;
}
return null;

and from that I assume either the announce is happening before the IPv4 listener has bound to a local port... or something else funky is going on. I wonder if there should be another fallback, which is to just return the port you configured the listener with. If it was configured with a specific port (i.e. 12345) that value can be sent to the tracker even if the listener has not yet successfully bound to that port (potentially because some other app is currently using the port).

from monotorrent.

alanmcgovern avatar alanmcgovern commented on June 7, 2024

This should be fixed in master now!

from monotorrent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.