Giter VIP home page Giter VIP logo

Comments (5)

glowdan avatar glowdan commented on June 22, 2024 6

OK,I solved it. If we need insert or save data to db, we add the reference to the first param.

            if (PHP_VERSION_ID > 70000 && in_array($method, ['insert', 'batchInsert', 'save'])) {
                $saveData = array_shift($param);
                $saveParams = array_shift($param);
                if (NULL==$saveParams) {
                    $saveParams = [];
                }
                $re = call_user_func_array([$collection, $method], [&$saveData, $saveParams]);
            } else {
                $re = call_user_func_array([$collection, $method], $param);
            }

from mongo-php-adapter.

Ardakilic avatar Ardakilic commented on June 22, 2024 1

@glowdan can you please elaborate more ? Where did you add this patch ?

I'm using https://github.com/jenssegers/laravel-mongodb with Laravel 4.2.x along with PHP7.0, and this is the only step I'm struggling with.

from mongo-php-adapter.

rhclayto avatar rhclayto commented on June 22, 2024 1

@Ardakilic Check this out: LearningLocker/learninglocker#893

from mongo-php-adapter.

alcaeus avatar alcaeus commented on June 22, 2024

Unfortunately, insert, batchInsert and save can't be implemented the way they were in the legacy driver:

The insert, batchInsert, and save methods take the first argument by reference. While the original API does not explicitely specify by-reference arguments it does add an ID field to the objects and documents given.

I had the choice:

  1. have the first argument by-value: this would have allowed passing a value to the method but the array will be lacking the _id value that is added by the driver
  2. have the first argument by-reference: this would fix the _id problem but the method signatures would be incompatible.

The original intent of the driver was to have the argument by-reference so that an auto-generated ID could be added. Thus, I settled for option #2, knowing that people can either handle that specific warning in an error handler or ignore it. On the other hand, having code break because you were expecting an _id field in your array seems a lot more severe.

TL;DR: I wouldn't recommend it.

from mongo-php-adapter.

Ardakilic avatar Ardakilic commented on June 22, 2024

Thanks @rhclayto , will look right away!

from mongo-php-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.