Comments (2)
I have found the cause of this behavior.
After an ajax 'read', items not yet in memory are passed to @collection.items.create(item, *args)
I.E. the create() method on the backbone collection. The following then happens:
- model created from item
- model added to collection with server attributes.
- ( collection add event )
- model.save()
- Model.save() triggers an Offline.sync() 'update'.
- model gets a local guid, and is saved to local-storage.
I'm not familiar with the framework, so may be missing something. But I thought create + PUT were for newly created entities, not all entities on the server (when they are first fetched).
Here - the purpose seems to be a way to get a 'cid' assigned by the collection, before saving the model to localstorage. I'm gussing this is a hack to avoid calling collection._prepareModel() from outside the collection.
But I can't yet think of a way to fix the 'double add-event' bug without changing the control flow.
Calling _prepareModel() outside collection is bad practice. But if you were flexible on this, would solve bug, and control flow would be much simpler + more intuitive.
One way to make this 'better' practice might be to implement Backbone.Offline using a special Collection subclass, and make a public gateway to _prepareModel().
I personally find this a nice way to implement Offline in my project anyway. I have an OnlineCollection class:
var OfflineCollection = Backbone.Collection.extend({
storageName: 'default',
initialize: function() {
console.log('setting up storage for '+ this.storageName)
this.storage = new Offline.Storage( this.storageName, this );
}
});
Nice for DRY - just put storageName in subclass.
But maybe you guys want to touch as little of the Backbone prototypes as possible - which is understandable. Any other suggestions to fix this?
In short run I have deadline, so may have to make my own non-standard branch. In mid term, very much look forward to discussion - I'm happy to contribute to this project!
Dalip
from backbone-offline.
This sounds very similar to an issue I'm having where the success method of particular fetch is called twice when the collection is not in localStorage. This in turn, causes an error for my control flow situation because it returns an empty collection on success the first time, then later returns the populated collection after the success magic has already happened with an empty collection.
from backbone-offline.
Related Issues (20)
- Fetch a simple Model ? HOT 4
- Fetch Local dont work with Backbone 1.0 HOT 4
- Bug with Storage#clear
- Collection is empty on fetching. Errors on POST request. HOT 5
- "Record Not Found" when fetching a model HOT 2
- Backbone.js offline not saving to local storage after fetch HOT 1
- error on fetch/pull HOT 3
- Backbone 1.0 and Backbone 0.9.10 compatibility difference
- Server implementation HOT 3
- Creates duplicate records if id is string HOT 1
- Option to use mongo objectid generator
- sync.push error
- collection.storage.sync.push() issue
- id not sent with this.model.save() HOT 1
- want to track the count of un-synced HTTP CRUD events
- delete que is never empty HOT 1
- Need help with updating related keys in multiple collections
- .storage.sync.full() alle Model data gets dirty HOT 1
- Using backbone-offline in conjuction with backbone.iobind?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backbone-offline.