Giter VIP home page Giter VIP logo

Comments (8)

HarukaMa avatar HarukaMa commented on September 27, 2024 2

strange, lemme try to isolate this then. I'm getting another strange panic right now:

thread 'tokio-runtime-worker' panicked at 'assertion failed: previous_atomic_depth != 0', /home/mrx/snarkVM/ledger/store/src/helpers/rocksdb/internal/map.rs:217:9                                                note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I'll try to revert some commits to see which one caused this.

from snarkos.

ljedrz avatar ljedrz commented on September 27, 2024 1

I just tested it with a fully synced client node, and indeed, it speeds things up.

  • baseline (testnet3): 119.45s
  • with the linked snarkVM PR: 41.75s (-65%)

from snarkos.

HarukaMa avatar HarukaMa commented on September 27, 2024 1

I've confirmed that PR significantly speeds up the startup time, and it scales especially well with high core counts.

The remaining feature request would be to provide some feedback on what the node is trying to do - even with verbosity 3 there is only a "Starting a client node" message.

from snarkos.

ljedrz avatar ljedrz commented on September 27, 2024

I'll bring AleoNet/snarkVM#1606 up to date, it should speed it up.

from snarkos.

HarukaMa avatar HarukaMa commented on September 27, 2024

From #2903 (comment):

Sometimes the following panic happens and the node stops syncing:

thread 'tokio-runtime-worker' panicked at 'assertion failed: self.database.atomic_batch.lock().is_empty()', /home/mrx/snarkVM/ledger/store/src/helpers/rocksdb/internal/map.rs:111:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2023-12-15T09:19:18.114699Z  WARN snarkos_node::client::router: Disconnecting from '...' - task 70531 panicked  

then:

2023-12-15T09:19:20.478289Z  WARN snarkos_node_sync::block_sync: The next block (969045) is invalid - Cannot start an atomic batch write operation while another one is already in progress.

If this is not caused by that PR, is it possible that this is introduced by the snarkVM PR instead?

from snarkos.

ljedrz avatar ljedrz commented on September 27, 2024

The startup speed-up one? I don't think so, it's most likely a separate new issue.

from snarkos.

ljedrz avatar ljedrz commented on September 27, 2024

The remaining feature request would be to provide some feedback on what the node is trying to do - even with verbosity 3 there is only a "Starting a client node" message.

Done.

from snarkos.

HarukaMa avatar HarukaMa commented on September 27, 2024

closing as the snarkvm pr is closed

from snarkos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.