Notice of AGPL3 License Violation about apple-music-desktop HOT 6 OPEN

@quacksire This doesn't use anything from Cider?

It uses stuff from apple-music-electron.

But in any case, how should I fix this?

from apple-music-desktop.

Hello,

Since Qwack is not replying to this, I will handle this on behalf of the team.

If you could remove any reference to Cider in your codebase, notably the client-preload.js which has clearly been copied word by word from our version, including the logs referring to it, or if you continue to use this code please follow the AGPL license rules and adopt this license.

As Cider has now been archived and I understand that there is not much on GitHub for Apple Music, this will not go any further than this. As far as I can see, the majority of the functionality you have copied, you have not even used. So I suggest removing it and rewriting as necessary.

Thank you for your cooperation.

from apple-music-desktop.

@coredev-uk I will do both. Update the license and remove unneeded stuff from the preload script. I'm mainly just using a few musickit stuff from it to allow pausing/playing from the tray and menu.

from apple-music-desktop.

In that case, all you will need is to hook into PlaybackStateHasChanged (or WillChange) and/or NowPlayingHasChanged with just an IPC call to send the current playing item.

If you want to know more about the types I suggest taking a look at our types for MusicKit.

from apple-music-desktop.

@coredev-uk Yeah, I looked at that, but I am still keeping the file around as client-preload.bak. It isn't used in the app anymore, or included in the installers. Just keeping it around as a backup reference, as looking through and seeing examples made it alot easier for me to come up with my own, simplified implementation, rather than reading through the apple docs (although the docs did help me with getting track info to make a new popup window to show the track name/album/artist when in docked/tray mode.)

The whole point of this project was because apple-music-electron was broken, and I tried and tried but couldn't fix it. I was trying to update the npm deps and electron version, and change a few minor UI things. I gave up and decided to make my own app from scratch, but I did use the file from Cider originally, since I knew it worked and Cider still works and can be built from source properly even though it's deprecated.

Should I still modify the license since the file is in the repo? Or can I exclude it since it isn't actually built into the product or installer.

from apple-music-desktop.

Just throw it in a docs folder outside the src and remove any direct references to cider, that should be all. As for apple-music-electron, its a very hard to keep it going since its highly dependant on Apple's site, hence the reason why we made Cider, just the paywalled nature of the application is a regrettable circumstance of our expanded user base.

I wish you good luck for this and hope it goes well and thanks again for following this.

from apple-music-desktop.