Giter VIP home page Giter VIP logo

Comments (1)

alexander-albers avatar alexander-albers commented on June 19, 2024

To be more specific: The issue seems to be that POI locations are not resolved correctly when supplying them in a trip request. There may exist another station with the same id as the POI location, in which case the station will be used instead for the routing.

The VRS app uses the following format for encoding locations:
Station (from): ft=<name>&fs=<place>&fc=<lat>,<lon>&f=<id>
POI (to): tt=<name>&ts=<place>&t=<lat>,<lon>

This means that POIs should never use a location id, and we should probably never parse the "tempId" as a POI id, as done here:

tripkit/Sources/TripKit/Provider/Implementations/VrsProvider.swift

Lines 1117 to 1121 in 0afa2b2

} else if let poiName = location["name"] as? String {
locationType = .poi
if let tmpId = location["tempId"] as? Int {
id = "\(tmpId)"
}

cc @schildbach public-transport-enabler

from tripkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.