Pass additional parameters to :candidates function about compliment HOT 7 CLOSED

Can you perhaps use a dynamic variable for that?

from compliment.

Yes I think I can 😄 Good idea!

from compliment.

Well actually orchard, or cider-nrepl already use that and I was hoping to pass things in compliment.core, which is good for testing, however changing the interface it's probably the worst possible choice here

from compliment.

Here is the call to cljs-tooling, for completeness (pun unintended) - https://github.com/clojure-emacs/cider-nrepl/blob/master/src/cider/nrepl/middleware/complete.clj#L10-L20

from compliment.

I have a working version with a dynamic car but it hurts the eye a bit.

I would like to propose one change that would not be breaking:

[... & option-map]

That way any source implementation can pass the key it desires.

What do you think @alexander-yakushev?

from compliment.

I would like to see first how the dynamic var implementation looks like. If it is really ugly, I'm fine with the extra optional argument.

from compliment.

Closing this because I am using a dynamic var in #62 now.

from compliment.