Giter VIP home page Giter VIP logo

Comments (9)

alexanderepstein avatar alexanderepstein commented on May 31, 2024

@luchillo17
Interestingly enough i was able to reproduce your bug everytime, however when running the full source code uncompiled it works.This only occurs on windows so for now I would say just downgrade to 1.1.0. I am planning on releasing version 1.3.0 tomorrow which contains a whole new way of storing the settings that is more reliable.

from sandman.

alexanderepstein avatar alexanderepstein commented on May 31, 2024

@luchillo17 updated to 1.3.0

from sandman.

luchillo17 avatar luchillo17 commented on May 31, 2024

Nice 😄

from sandman.

luchillo17 avatar luchillo17 commented on May 31, 2024

@alexanderepstein Actually the app showed me a popup and sent me to the update page... of V1.2.0, maybe it's better to just send the user to the general releases url instead of the url of the next version, after all the most recent version will still be first in that url:
https://github.com/alexanderepstein/Insomnia/releases

from sandman.

luchillo17 avatar luchillo17 commented on May 31, 2024

Tested V1.3.0 and settings save correctly, now what i see is that no matter what i choose, the time is always in military mode.

from sandman.

alexanderepstein avatar alexanderepstein commented on May 31, 2024

@luchillo17 huh thats so weird since the default time preference and the military time preference both utilize the same logic. I did realize however i was sending the user to the current release of Insomnia and that still exists in 1.3.0. Just a variable name change and it should work now. I will have to test out the military time thing on a windows system to check out the console and see if and errors are thrown.

from sandman.

luchillo17 avatar luchillo17 commented on May 31, 2024

What's broken is not the preferences save, is the display between military and default mode, if i change between them, the time still shows in military mode.

Btw could you make available the DevTools? most of us in github are developers, and we can help debug the issue if we can reach the DevTools, but so far i see no button and none standard keyboard shortcuts works.

from sandman.

alexanderepstein avatar alexanderepstein commented on May 31, 2024

@luchillo17 I know what the issue is it has to do with the declaration of a different settings variable in main.js versus script.js. I need to implement a mixture between my old settings methodolgy and my new one. As for devtools I don't think it would look nice to have a button for it and when you don't have them set up to open the keyboard shortcuts doesn't work either. To see the devtools you'll have to clone electron cd to the folder run npm install then go into main.js and uncomment the two lines win.openDevtools and pref.openDevTools

from sandman.

alexanderepstein avatar alexanderepstein commented on May 31, 2024

Hopefully all this is fixed in 1.4.0

from sandman.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.