Giter VIP home page Giter VIP logo

Comments (5)

joroKr21 avatar joroKr21 commented on May 30, 2024 1

I forgot auto closing doesn't work from comments. This is fixed now.

from scalacheck-shapeless.

joroKr21 avatar joroKr21 commented on May 30, 2024

That's to be expected since MkHListCogen and MkCoproductCogen are Strict in the head. I don't know if this is intended, because sometimes special care is needed to deal with recursive types (e.g. Gen.lzy). But you can try to use Lazy and see what happens.

from scalacheck-shapeless.

torgeirsh avatar torgeirsh commented on May 30, 2024

Changing the head to Lazy makes the expression Cogen[T1.Tree] compile successfully, but I don't know if the generated value is correct. Would be great if someone who is familiar with the internals could take a look.

from scalacheck-shapeless.

joroKr21 avatar joroKr21 commented on May 30, 2024

Actually the generic Repr implicits are already wrapped in Lazy here. So support for recursive types is intended. I think the issue is that calling contramap in the implementation forces evaluation too early. Replacing it with this seems to work:

instance(Cogen { (seed: Seed, p: P) =>
  cogen.value.cogen.perturb(seed, gen.to(p))
})

Note how cogen.value.cogen is not forced until the perturb function is actually called. Would you like to make a PR with this fix and the added test with T1.Tree?

from scalacheck-shapeless.

alexarchambault avatar alexarchambault commented on May 30, 2024

Should be fixed in master, yep. I'll do a release once #73 and #74 are settled.

from scalacheck-shapeless.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.